Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Dec 16, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on the deletion of numerous asset files from the apps/dashboard/public/assets directory, including images related to partners, ambassadors, landing pages, grants, and startup programs.

Detailed summary

  • Deleted multiple image files from partners, ambassadors, landingpage, and community directories.
  • Removed various icons and graphics used in grants and startup programs.
  • Cleaned up assets related to specific projects and initiatives.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Dec 16, 2024

@vercel
Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 9:33pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 16, 2024 9:33pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 16, 2024 9:33pm
wallet-ui ⬜️ Skipped (Inspect) Dec 16, 2024 9:33pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 16, 2024 20:57 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 16, 2024 20:57 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 16, 2024 20:57 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Dec 16, 2024

⚠️ No Changeset found

Latest commit: 2110792

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MananTank MananTank changed the title [DASH-639] Remove unused asssets [DASH-639] Remove unused asssets #3 Dec 16, 2024
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 16, 2024
@MananTank MananTank changed the title [DASH-639] Remove unused asssets #3 [DASH-639] Remove unused asssets Dec 16, 2024
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review December 16, 2024 20:57
@MananTank MananTank changed the title [DASH-639] Remove unused asssets [DASH-639] Remove unused assets Dec 16, 2024
@codecov
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.99%. Comparing base (ba685b9) to head (2110792).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5759      +/-   ##
==========================================
- Coverage   53.01%   52.99%   -0.02%     
==========================================
  Files        1101     1102       +1     
  Lines       59079    59107      +28     
  Branches     4807     4809       +2     
==========================================
+ Hits        31318    31323       +5     
- Misses      27043    27066      +23     
  Partials      718      718              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 89efc28
packages 50.13% <ø> (-0.02%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 2 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.93 KB (+0.07% 🔺) 899 ms (+0.07% 🔺) 2.4 s (-17.04% 🔽) 3.3 s
thirdweb (cjs) 110.84 KB (0%) 2.3 s (0%) 5 s (-11.95% 🔽) 7.3 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 388 ms (+35.09% 🔺) 500 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 88 ms (+3.91% 🔺) 98 ms
thirdweb/react (minimal + tree-shaking) 19.07 KB (0%) 382 ms (0%) 561 ms (-26.16% 🔽) 942 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 16, 2024

Merge activity

jnsdls pushed a commit that referenced this pull request Dec 16, 2024
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on the deletion of numerous asset files from the `apps/dashboard/public/assets` directory, which includes images related to partners, ambassadors, landing pages, grants, and startup programs.

### Detailed summary
- Deleted multiple image files from `apps/dashboard/public/assets/partners`
- Removed various ambassador-related images from `apps/dashboard/public/assets/ambassadors`
- Cleared out several landing page images from `apps/dashboard/public/assets/landingpage`
- Eliminated images associated with grants and startup programs from `apps/dashboard/public/assets/grant` and `apps/dashboard/public/assets/startup-program` respectively
- Removed community and product page images from the respective directories

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 12-17-_dash-639_remove_unused_asssets branch from aedc177 to 850411e Compare December 16, 2024 21:08
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 16, 2024 21:08 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 16, 2024 21:08 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 16, 2024 21:08 Inactive
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on the deletion of numerous image files from various directories within the `apps/dashboard/public/assets` folder, including images related to partners, ambassadors, landing pages, and grants.

### Detailed summary
- Deleted multiple image files from `partners`, `ambassadors`, `landingpage`, `community`, and `grant` directories.
- Removed images such as `aws.png`, `polygon.png`, `coinbase.png`, `superchain/logo-dashboard.png`, and many others.
- A total of 160 image files were deleted.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 12-17-_dash-639_remove_unused_asssets branch from 850411e to 2110792 Compare December 16, 2024 21:13
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 16, 2024 21:13 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 16, 2024 21:13 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 16, 2024 21:13 Inactive
@graphite-app graphite-app bot merged commit 2110792 into main Dec 16, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 12-17-_dash-639_remove_unused_asssets branch December 16, 2024 21:34
@vercel vercel bot temporarily deployed to Production – docs-v2 December 16, 2024 21:34 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui December 16, 2024 21:34 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 16, 2024 21:34 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants