Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Dec 17, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on improving the layout and structure of the components in the insight and blueprint-playground files, enhancing responsiveness and visual organization.

Detailed summary

  • Updated styles in page.tsx for better layout and spacing.
  • Replaced useHeightObserver with ScrollShadow in blueprint-playground.client.tsx.
  • Adjusted height handling for sections to improve responsiveness.
  • Added overflow-hidden to RequestConfigSection for better scrolling behavior.
  • Removed unused isMobileViewport functionality.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Dec 17, 2024

@changeset-bot
Copy link

changeset-bot bot commented Dec 17, 2024

⚠️ No Changeset found

Latest commit: 9b3c7f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 8:47pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 17, 2024 8:47pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 17, 2024 8:47pm
wallet-ui ⬜️ Skipped (Inspect) Dec 17, 2024 8:47pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 December 17, 2024 20:20 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 17, 2024 20:20 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 17, 2024 20:20 Inactive
@MananTank MananTank marked this pull request as ready for review December 17, 2024 20:20
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 17, 2024
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank force-pushed the 12-18-_insight-508_fix_insight_blueprint_card_alignment_set_max_height_on_blueprint_playground branch from acb0cc1 to 0395449 Compare December 17, 2024 20:22
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 17, 2024 20:22 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 17, 2024 20:22 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 17, 2024 20:22 Inactive
@codecov
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.99%. Comparing base (69990ab) to head (9b3c7f6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5778   +/-   ##
=======================================
  Coverage   52.99%   52.99%           
=======================================
  Files        1102     1102           
  Lines       59107    59107           
  Branches     4809     4809           
=======================================
  Hits        31323    31323           
  Misses      27066    27066           
  Partials      718      718           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 69990ab
packages 50.13% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.93 KB (0%) 899 ms (0%) 197 ms (+82.78% 🔺) 1.1 s
thirdweb (cjs) 110.84 KB (0%) 2.3 s (0%) 290 ms (+2.58% 🔺) 2.6 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 32 ms (+79.56% 🔺) 143 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 8 ms (+81.22% 🔺) 18 ms
thirdweb/react (minimal + tree-shaking) 19.07 KB (0%) 382 ms (0%) 28 ms (+35% 🔺) 410 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 17, 2024

Merge activity

…n blueprint playground (#5778)

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on improving the layout and structure of the `BlueprintPlaygroundUI` component in the `blueprint-playground.client.tsx` file and enhancing the styling of the `page.tsx` file in the `insight` directory.

### Detailed summary
- Updated the layout of the `BlueprintPlaygroundUI` component.
- Replaced `useHeightObserver` with `ScrollShadow`.
- Adjusted height and overflow properties for responsive design.
- Enhanced the styling of the `insight/page.tsx` component.
- Added a new `ScrollShadow` wrapper around `ParameterSection` components.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 12-18-_insight-508_fix_insight_blueprint_card_alignment_set_max_height_on_blueprint_playground branch from 0395449 to 9b3c7f6 Compare December 17, 2024 20:39
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 17, 2024 20:39 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 17, 2024 20:39 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 17, 2024 20:39 Inactive
@graphite-app graphite-app bot merged commit 9b3c7f6 into main Dec 17, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 12-18-_insight-508_fix_insight_blueprint_card_alignment_set_max_height_on_blueprint_playground branch December 17, 2024 20:48
@vercel vercel bot temporarily deployed to Production – wallet-ui December 17, 2024 20:48 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 17, 2024 20:48 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 December 17, 2024 20:48 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants