[ci] Chore: Update codeowners #5781
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
|
|
||
| # default ownership group | ||
| - @jnsdls @joaquim-verges @MananTank @gregfromstl | ||
| @thirdweb-dev/developer-tools |
There was a problem hiding this comment.
The default owner syntax appears incorrect. The line should be * @thirdweb-dev/developer-tools to properly match all files in the repository. The current hyphen prefix is not valid CODEOWNERS syntax and will not work as intended.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5781 +/- ##
=======================================
Coverage 52.99% 52.99%
=======================================
Files 1102 1102
Lines 59107 59107
Branches 4809 4809
=======================================
Hits 31323 31323
Misses 27066 27066
Partials 718 718
*This pull request uses carry forward flags. Click here to find out more. |
Merge activity
|
<!-- start pr-codex -->
## PR-Codex overview
This PR updates the ownership and environment variables in the GitHub workflows and `CODEOWNERS` file, reflecting a shift in responsibilities and issue prefix definitions.
### Detailed summary
- Changed `VALID_ISSUE_PREFIXES` from `"CNCT|DASH|PROT|INSIGHT|ENGINE|CS|DES|BIL|DEVX|SOLU|NEB"` to `"CORE|TOOL"`.
- Updated default ownership group in `.github/CODEOWNERS` to `@thirdweb-dev/developer-tools`.
- Adjusted package ownerships for `packages/thirdweb/`, `packages/service-utils/`, `packages/eslint-config-thirdweb/`, and `packages/tw-tsconfig/` to include `@thirdweb-dev/core-platform` and `@edwardysun`.
- Changed app ownership for `apps/` to include `@thirdweb-dev/developer-tools` and `@thirdweb-dev/core-platform`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
jnsdls
force-pushed
the
greg/tool-2769-chore-update-codeowners-to-match-new-teams
branch
from
1a4527b to
871ad99
Compare
graphite-app
bot
deleted the
greg/tool-2769-chore-update-codeowners-to-match-new-teams
branch
PR-Codex overview
This PR updates the ownership configuration in the
.github/CODEOWNERSfile and modifies theVALID_ISSUE_PREFIXESin the.github/workflows/issue.yml. It reflects a shift in responsibility for various packages and apps to new teams, enhancing clarity in code ownership.Detailed summary
VALID_ISSUE_PREFIXESfrom"CNCT|DASH|PROT|INSIGHT|ENGINE|CS|DES|BIL|DEVX|SOLU|NEB"to"CORE|TOOL".@thirdweb-dev/developer-tools.packages/thirdweb/to@thirdweb-dev/core-platformand@thirdweb-dev/developer-tools.packages/service-utils/,packages/eslint-config-thirdweb/, andpackages/tw-tsconfig/now owned by@thirdweb-dev/core-platformand@edwardysun.apps/to include@thirdweb-dev/developer-toolsand@thirdweb-dev/core-platform.