Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Dec 17, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR enhances the ChatPageContent component by integrating the useActiveWalletChain hook, improving context filter management, and ensuring the current user's wallet address and chain ID are correctly set in the context filters.

Detailed summary

  • Added useActiveWalletChain to retrieve the active wallet chain.
  • Renamed _contextFilters to contextFilters for clarity.
  • Updated setContextFilters to a useCallback function.
  • Modified context filter logic to include active wallet address and chain ID.
  • Improved handling of new session conditions for context filters.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Dec 17, 2024

@vercel
Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 11:26pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 17, 2024 11:26pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 17, 2024 11:26pm
wallet-ui ⬜️ Skipped (Inspect) Dec 17, 2024 11:26pm

@changeset-bot
Copy link

changeset-bot bot commented Dec 17, 2024

⚠️ No Changeset found

Latest commit: ecb4571

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 December 17, 2024 21:26 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 17, 2024 21:26 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 17, 2024 21:26 Inactive
@MananTank MananTank marked this pull request as ready for review December 17, 2024 21:26
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 17, 2024
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.93 KB (0%) 899 ms (0%) 254 ms (+119.08% 🔺) 1.2 s
thirdweb (cjs) 110.84 KB (0%) 2.3 s (0%) 387 ms (+2.66% 🔺) 2.7 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 39 ms (+117.04% 🔺) 151 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 11 ms (+184.75% 🔺) 21 ms
thirdweb/react (minimal + tree-shaking) 19.07 KB (0%) 382 ms (0%) 57 ms (+33.05% 🔺) 439 ms

@codecov
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.99%. Comparing base (58bc4a9) to head (ecb4571).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5782   +/-   ##
=======================================
  Coverage   52.99%   52.99%           
=======================================
  Files        1102     1102           
  Lines       59107    59107           
  Branches     4809     4809           
=======================================
  Hits        31323    31323           
  Misses      27066    27066           
  Partials      718      718           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 58bc4a9
packages 50.13% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@MananTank MananTank force-pushed the 12-18-_core-645_nebula_-_add_active_chain_in_context_filters branch from ea0c5ba to 77c8836 Compare December 17, 2024 23:10
@MananTank MananTank requested review from a team as code owners December 17, 2024 23:10
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 17, 2024 23:10 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 17, 2024 23:10 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 17, 2024 23:10 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 17, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR enhances the `ChatPageContent` component by integrating the `useActiveWalletChain` hook, which allows the component to manage context filters based on the user's active wallet chain. It refines state management and ensures context filters are updated appropriately.

### Detailed summary
- Added `useActiveWalletChain` to track the active wallet chain.
- Renamed the state variable `_contextFilters` to `contextFilters`.
- Updated the `setContextFilters` function to use `useCallback`.
- Modified the logic to update context filters based on active wallet address and chain ID.
- Simplified the effect to set context filters conditionally based on user interactions and active chain.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 12-18-_core-645_nebula_-_add_active_chain_in_context_filters branch from 77c8836 to ecb4571 Compare December 17, 2024 23:23
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 17, 2024 23:23 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 17, 2024 23:23 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 17, 2024 23:23 Inactive
@graphite-app graphite-app bot merged commit ecb4571 into main Dec 17, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 12-18-_core-645_nebula_-_add_active_chain_in_context_filters branch December 17, 2024 23:27
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 17, 2024 23:27 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 December 17, 2024 23:27 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui December 17, 2024 23:27 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants