Skip to content

Conversation

@GiselleNessi
Copy link
Contributor

@GiselleNessi GiselleNessi commented Dec 18, 2024

Problem solved

Added a guide for registering Ecosystem Wallet with WalletConnect (Reown)


PR-Codex overview

This PR focuses on integrating WalletConnect registration into the thirdweb ecosystem, updating the sidebar and adding detailed instructions for users on how to register their wallets with WalletConnect, now known as Reown.

Detailed summary

  • Added new registration option for WalletConnect in the sidebar.
  • Updated register-walletconnect page with a guide on registering wallets.
  • Included images for visual support in the registration process.
  • Provided step-by-step instructions for creating and submitting a project in Reown.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: 7d5d615

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 8:08pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 8:08pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 8:08pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 8:08pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 18, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Dec 18, 2024
@codecov
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.02%. Comparing base (7d8566e) to head (7d5d615).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5786   +/-   ##
=======================================
  Coverage   53.02%   53.02%           
=======================================
  Files        1101     1101           
  Lines       59080    59080           
  Branches     4810     4810           
=======================================
  Hits        31328    31328           
  Misses      27034    27034           
  Partials      718      718           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from fccd26e
packages 50.16% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.94 KB (0%) 899 ms (0%) 482 ms (+2.54% 🔺) 1.4 s
thirdweb (cjs) 110.85 KB (0%) 2.3 s (0%) 835 ms (+6.07% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 104 ms (+112.47% 🔺) 216 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 58 ms (+115.2% 🔺) 68 ms
thirdweb/react (minimal + tree-shaking) 19.07 KB (0%) 382 ms (0%) 243 ms (+327.19% 🔺) 625 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 18, 2024

Merge activity

  • Dec 18, 8:02 PM UTC: @GiselleNessi we removed the merge queue label because we could not find a Graphite account associated with your GitHub profile.

You must have a Graphite account in order to use the merge queue. Create an account and try again using this link

  • Dec 18, 3:08 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Dec 18, 2024
@GiselleNessi GiselleNessi added the merge-queue Adds the pull request to Graphite's merge queue. label Dec 18, 2024
@gregfromstl gregfromstl merged commit 59ec04d into main Dec 18, 2024
31 checks passed
@gregfromstl gregfromstl deleted the gi/ecosystem-wallet-docs-update branch December 18, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-queue Adds the pull request to Graphite's merge queue. Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants