Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Dec 18, 2024

Problem solved

Fixes XPROD-943


PR-Codex overview

This PR focuses on enhancing the documentation and configuration options for in-app and ecosystem wallets, including new features, improved examples, and better organization of sidebar links.

Detailed summary

  • Added new section on resolving ipfs:// URIs using resolveScheme.
  • Updated sidebar links for better navigation.
  • Enhanced in-app wallet documentation with examples for guest and custom JWT authentication.
  • Introduced ecosystem wallet configuration details.
  • Improved API references for wallet functionalities.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 18, 2024 01:13 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 18, 2024 01:13 Inactive
@vercel
Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 10:06am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 10:06am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 10:06am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 10:06am

@vercel vercel bot temporarily deployed to Preview – wallet-ui December 18, 2024 01:13 Inactive
@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Dec 18, 2024
Copy link
Member Author

joaquim-verges commented Dec 18, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: ccb4873

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.03%. Comparing base (ecb4571) to head (ccb4873).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5787      +/-   ##
==========================================
+ Coverage   52.99%   53.03%   +0.04%     
==========================================
  Files        1102     1101       -1     
  Lines       59107    59079      -28     
  Branches     4809     4812       +3     
==========================================
+ Hits        31323    31333      +10     
+ Misses      27066    27028      -38     
  Partials      718      718              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from f6d5d10
packages 50.18% <ø> (+0.04%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
packages/thirdweb/src/wallets/in-app/web/in-app.ts 60.00% <ø> (ø)

... and 5 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.93 KB (0%) 899 ms (0%) 567 ms (-7.52% 🔽) 1.5 s
thirdweb (cjs) 110.84 KB (0%) 2.3 s (0%) 1.2 s (-13.93% 🔽) 3.4 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 206 ms (+123.2% 🔺) 317 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 31 ms (-23.82% 🔽) 41 ms
thirdweb/react (minimal + tree-shaking) 19.07 KB (0%) 382 ms (0%) 197 ms (+26.32% 🔺) 579 ms

@joaquim-verges joaquim-verges force-pushed the feat_Reorganize_portal_landing_page_sections branch from 276da55 to f6d5d10 Compare December 18, 2024 01:22
@joaquim-verges joaquim-verges force-pushed the docs_Reorganize_TypeScript_and_React_documentation_structure branch from 04ea868 to 7e544ae Compare December 18, 2024 01:22

<DocImage src={EcosystemSocialConfig}/>

For prebuilt UIs, the enabled auth strategies are automatically read from your dashbaord configurations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix typo: dashbaord -> dashboard

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@linear
Copy link

linear bot commented Dec 18, 2024

@joaquim-verges joaquim-verges force-pushed the docs_Reorganize_TypeScript_and_React_documentation_structure branch from 7e544ae to ccb4873 Compare December 18, 2024 09:55
@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Dec 18, 2024
Base automatically changed from feat_Reorganize_portal_landing_page_sections to main December 18, 2024 20:57
@joaquim-verges joaquim-verges merged commit 5293450 into main Dec 18, 2024
29 of 31 checks passed
@joaquim-verges joaquim-verges deleted the docs_Reorganize_TypeScript_and_React_documentation_structure branch December 18, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Portal Involves changes to the Portal (docs) codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants