Skip to content

adds missing async to connect docs #5789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

adds missing async to connect docs #5789

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb8e70c
adds missing async to connect docs (#5789)
nischitpra Dec 18, 2024
6d3329e
Merge branch 'main' into np/minorfixes
nischitpra Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/portal/src/app/connect/in-app-wallet/custom-auth/configuration/page.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ import { useConnect } from "thirdweb/react";
const { connect } = useConnect();

const handlePostLogin = async (jwt: string) => {
await connect(() => {
await connect(async () => {
const wallet = inAppWallet();
await wallet.connect({
client,
Expand Down
6 changes: 3 additions & 3 deletions apps/portal/src/app/connect/in-app-wallet/guides/build-your-own-ui/page.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ import { useConnect } from "thirdweb/react";
const { connect } = useConnect();

const handleLogin = async () => {
await connect(() => {
await connect(async () => {
const wallet = inAppWallet();
await wallet.connect({
client,
Expand Down Expand Up @@ -137,7 +137,7 @@ const preLogin = async (email: string) => {

const handleLogin = async (email: string, verificationCode: string) => {
// verify email and connect
await connect(() => {
await connect(async () => {
const wallet = inAppWallet();
await wallet.connect({
client,
Expand Down Expand Up @@ -194,7 +194,7 @@ import { inAppWallet, hasStoredPasskey } from "thirdweb/wallets/in-app";
const { connect } = useConnect();

const handleLogin = async () => {
await connect(() => {
await connect(async () => {
const wallet = inAppWallet();
const hasPasskey = await hasStoredPasskey(client);
await wallet.connect({
Expand Down
8 changes: 4 additions & 4 deletions apps/portal/src/app/react/v5/in-app-wallet/build-your-own-ui/page.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ import { useConnect } from "thirdweb/react";
const { connect } = useConnect();

const handleLogin = async () => {
await connect(() => {
await connect(async () => {
const wallet = inAppWallet();
await wallet.connect({
client,
Expand Down Expand Up @@ -113,7 +113,7 @@ const preLogin = async (email: string) => {

const handleLogin = async (email: string, verificationCode: string) => {
// verify email and connect
await connect(() => {
await connect(async () => {
const wallet = inAppWallet();
await wallet.connect({
client,
Expand Down Expand Up @@ -144,7 +144,7 @@ const preLogin = async (phoneNumber: string) => {

const handleLogin = async (phoneNumber: string, verificationCode: string) => {
// verify phone number and connect
await connect(() => {
await connect(async () => {
const wallet = inAppWallet();
await wallet.connect({
client,
Expand All @@ -171,7 +171,7 @@ import { inAppWallet, hasStoredPasskey } from "thirdweb/wallets/in-app";
const { connect } = useConnect();

const handleLogin = async () => {
await connect(() => {
await connect(async () => {
const wallet = inAppWallet({
auth: {
passkeyDomain: "example.com", // defaults to current url
Expand Down
Loading