Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Dec 18, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on enhancing the Chats component by modifying transaction handling to use useSendTransaction and updating the SendTransactionButton to improve transaction execution with better error handling and client integration.

Detailed summary

  • Updated client initialization in ChatPageContent.tsx to use props.authToken.
  • Replaced SendTransactionButton with ExecuteTransaction in Chats.tsx.
  • Introduced ExecuteTransaction function to handle transaction execution.
  • Refactored SendTransactionButton to use useSendTransaction.
  • Improved error handling in transaction execution.
  • Passed client prop to SendTransactionButton for better integration.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Dec 18, 2024

@vercel
Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 0:24am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 19, 2024 0:24am
thirdweb_playground ⬜️ Skipped (Inspect) Dec 19, 2024 0:24am
wallet-ui ⬜️ Skipped (Inspect) Dec 19, 2024 0:24am

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 18, 2024 21:35 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 18, 2024 21:35 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: 46a426b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 December 18, 2024 21:35 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 18, 2024
@MananTank MananTank marked this pull request as ready for review December 18, 2024 21:36
@MananTank MananTank requested review from a team and jakubkrehel as code owners December 18, 2024 21:36
Copy link
Member Author

MananTank commented Dec 18, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.02 KB (0%) 901 ms (0%) 650 ms (+42.17% 🔺) 1.6 s
thirdweb (cjs) 110.76 KB (0%) 2.3 s (0%) 1.3 s (-21.05% 🔽) 3.5 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 168 ms (+308.06% 🔺) 279 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 31 ms (+38.06% 🔺) 41 ms
thirdweb/react (minimal + tree-shaking) 19.1 KB (0%) 383 ms (0%) 248 ms (+60.32% 🔺) 630 ms

@codecov
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.01%. Comparing base (7711efe) to head (46a426b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5797   +/-   ##
=======================================
  Coverage   53.01%   53.01%           
=======================================
  Files        1101     1101           
  Lines       59096    59096           
  Branches     4813     4813           
=======================================
  Hits        31329    31329           
  Misses      27049    27049           
  Partials      718      718           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 7711efe
packages 50.15% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 18, 2024

Merge activity

…ction hook (#5797)

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the transaction handling in the `Chats` component by improving the transaction execution process and ensuring the use of an authenticated `ThirdwebClient`.

### Detailed summary
- Updated `client` initialization in `ChatPageContent` to include `props.authToken`.
- Introduced `ExecuteTransaction` component to handle transaction execution.
- Replaced `SendTransactionButton` with `ExecuteTransaction` in `Chats`.
- Refactored `SendTransactionButton` to use `useSendTransaction` instead of `sendTransaction`.
- Simplified error handling for transaction data parsing.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@joaquim-verges joaquim-verges force-pushed the 12-19-_core-654_nebula_replace_sendtransaction_function_with_usesendtransaction_hook branch from 19cf8c1 to 46a426b Compare December 19, 2024 00:13
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 19, 2024 00:13 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 19, 2024 00:13 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 19, 2024 00:13 Inactive
@graphite-app graphite-app bot merged commit 46a426b into main Dec 19, 2024
24 of 32 checks passed
@graphite-app graphite-app bot deleted the 12-19-_core-654_nebula_replace_sendtransaction_function_with_usesendtransaction_hook branch December 19, 2024 00:27
@vercel vercel bot temporarily deployed to Production – docs-v2 December 19, 2024 00:27 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui December 19, 2024 00:27 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 19, 2024 00:27 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants