-
Notifications
You must be signed in to change notification settings - Fork 620
[TOOL-2808] Dashboard: Remove Announcement banner #5811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TOOL-2808] Dashboard: Remove Announcement banner #5811
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5811 +/- ##
=======================================
Coverage 53.34% 53.34%
=======================================
Files 1101 1101
Lines 59124 59124
Branches 4824 4824
=======================================
Hits 31541 31541
Misses 26864 26864
Partials 719 719
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on updating the handling of the `UnlimitedWalletsBanner` component in the dashboard application by removing its direct usage and replacing it with a placeholder comment, while also modifying the `knip.json` configuration to include an additional file in the ignore list.
### Detailed summary
- Updated `apps/dashboard/knip.json`: Added `src/components/notices/AnnouncementBanner.tsx` to the `ignore` array.
- Modified `apps/dashboard/src/pages/_app.tsx`: Replaced `<UnlimitedWalletsBanner />` with a comment `{/* Banner goes here */}`.
- Updated `apps/dashboard/src/app/layout.tsx`: Similarly replaced `<UnlimitedWalletsBanner />` with a comment `{/* Banner goes here */}`.
- Changed `AnnouncementBanner` function to `export function AnnouncementBanner`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
3eae1c7 to
8d17d05
Compare
|

Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on modifying the handling of the
UnlimitedWalletsBannercomponent within the dashboard, including its removal from certain files and updating theignorelist in theknip.jsonfile.Detailed summary
apps/dashboard/knip.jsonto includesrc/components/notices/AnnouncementBanner.tsxin theignorelist.UnlimitedWalletsBannercomponent fromapps/dashboard/src/pages/_app.tsxand replaced it with a comment.UnlimitedWalletsBannerfunction fromapps/dashboard/src/components/notices/AnnouncementBanner.tsx.apps/dashboard/src/app/layout.tsxto replaceUnlimitedWalletsBannerwith a comment.