Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Dec 19, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on modifying the handling of the UnlimitedWalletsBanner component within the dashboard, including its removal from certain files and updating the ignore list in the knip.json file.

Detailed summary

  • Updated apps/dashboard/knip.json to include src/components/notices/AnnouncementBanner.tsx in the ignore list.
  • Removed the UnlimitedWalletsBanner component from apps/dashboard/src/pages/_app.tsx and replaced it with a comment.
  • Removed the UnlimitedWalletsBanner function from apps/dashboard/src/components/notices/AnnouncementBanner.tsx.
  • Updated apps/dashboard/src/app/layout.tsx to replace UnlimitedWalletsBanner with a comment.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Dec 19, 2024

@vercel
Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 10:05pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 19, 2024 10:05pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 19, 2024 10:05pm
wallet-ui ⬜️ Skipped (Inspect) Dec 19, 2024 10:05pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 December 19, 2024 21:51 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 19, 2024 21:51 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 19, 2024 21:51 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 19, 2024
@MananTank MananTank marked this pull request as ready for review December 19, 2024 21:51
@MananTank MananTank requested review from a team as code owners December 19, 2024 21:51
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.34%. Comparing base (fd4664a) to head (8d17d05).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5811   +/-   ##
=======================================
  Coverage   53.34%   53.34%           
=======================================
  Files        1101     1101           
  Lines       59124    59124           
  Branches     4824     4824           
=======================================
  Hits        31541    31541           
  Misses      26864    26864           
  Partials      719      719           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from fd4664a
packages 50.56% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.02 KB (0%) 901 ms (0%) 2.2 s (-4.13% 🔽) 3.1 s
thirdweb (cjs) 110.76 KB (0%) 2.3 s (0%) 5.8 s (+16.62% 🔺) 8.1 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 271 ms (-7.87% 🔽) 383 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 100 ms (-1.35% 🔽) 110 ms
thirdweb/react (minimal + tree-shaking) 19.1 KB (0%) 383 ms (0%) 742 ms (-34.02% 🔽) 1.2 s

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 19, 2024

Merge activity

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the handling of the `UnlimitedWalletsBanner` component in the dashboard application by removing its direct usage and replacing it with a placeholder comment, while also modifying the `knip.json` configuration to include an additional file in the ignore list.

### Detailed summary
- Updated `apps/dashboard/knip.json`: Added `src/components/notices/AnnouncementBanner.tsx` to the `ignore` array.
- Modified `apps/dashboard/src/pages/_app.tsx`: Replaced `<UnlimitedWalletsBanner />` with a comment `{/* Banner goes here */}`.
- Updated `apps/dashboard/src/app/layout.tsx`: Similarly replaced `<UnlimitedWalletsBanner />` with a comment `{/* Banner goes here */}`.
- Changed `AnnouncementBanner` function to `export function AnnouncementBanner`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 12-20-_tool-2808_dashboard_remove_announcement_banner branch from 3eae1c7 to 8d17d05 Compare December 19, 2024 22:02
@changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2024

⚠️ No Changeset found

Latest commit: 8d17d05

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 December 19, 2024 22:02 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 19, 2024 22:02 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 19, 2024 22:02 Inactive
@graphite-app graphite-app bot merged commit 8d17d05 into main Dec 19, 2024
31 checks passed
@graphite-app graphite-app bot deleted the 12-20-_tool-2808_dashboard_remove_announcement_banner branch December 19, 2024 22:06
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 19, 2024 22:06 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui December 19, 2024 22:06 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 December 19, 2024 22:06 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants