Skip to content

[TOOL-2810] Remove unused assets from dashboard #5813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2024
Merged

[TOOL-2810] Remove unused assets from dashboard #5813

merged 1 commit into from
Dec 19, 2024

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Dec 19, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on the deletion of multiple asset files from the apps/dashboard/public/assets directory, including various images and templates related to contracts, icons, landing pages, and solutions.

Detailed summary

  • Deleted drop.png from add-contract
  • Deleted multiple template images, including:
    • nft-drop.png
    • tappyfowl.png
    • unity-iap.png
    • cat-attack.png
    • mintcaster.png
    • marketplace.png
    • nft-gallery.png
    • white-logo.png
    • expo-starter.png
    • next-starter.png
    • node-starter.png
    • thirdweb-eth.png
    • vite-starter.png
    • unity-pioneer.png
    • web3-warriors.png
    • nft-gated-site.png
    • unity-take-flight.png
    • unity-blockventure.png
    • phygital-experience.png
    • marketplace.png from solutions-pages/gaming

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Dec 19, 2024

TOOL-2810 Remove unused assets #4

@changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3d6e2a2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 11:07pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 19, 2024 11:07pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 19, 2024 11:07pm
wallet-ui ⬜️ Skipped (Inspect) Dec 19, 2024 11:07pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 December 19, 2024 22:11 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 19, 2024 22:11 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 19, 2024 22:11 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 19, 2024
@MananTank Graphite App
Copy link
Member Author

MananTank commented Dec 19, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Dec 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.34%. Comparing base (baa2157) to head (3d6e2a2).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5813   +/-   ##
=======================================
  Coverage   53.34%   53.34%           
=======================================
  Files        1101     1101           
  Lines       59124    59124           
  Branches     4824     4824           
=======================================
  Hits        31541    31541           
  Misses      26864    26864           
  Partials      719      719
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from baa2157
packages 50.56% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.02 KB (0%) 901 ms (0%) 815 ms (+66.35% 🔺) 1.8 s
thirdweb (cjs) 110.76 KB (0%) 2.3 s (0%) 1.5 s (+2.73% 🔺) 3.8 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 237 ms (+236.03% 🔺) 348 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 9 ms (-59.45% 🔽) 19 ms
thirdweb/react (minimal + tree-shaking) 19.1 KB (0%) 383 ms (0%) 220 ms (+45.85% 🔺) 602 ms

@MananTank MananTank marked this pull request as ready for review December 19, 2024 22:34
@MananTank MananTank requested review from a team and jakubkrehel as code owners December 19, 2024 22:34
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 19, 2024 •
edited
Loading

Merge activity

@MananTank
[TOOL-2810] Remove unused assets from dashboard (#5813)
3d6e2a2 
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on the removal of various asset files from the `apps/dashboard/public/assets` directory, including images and templates related to contracts, icons, and landing pages.

### Detailed summary
- Deleted the following files:
  - `add-contract/drop.png`
  - `tw-icons/nft-drop.png`
  - `templates/nft-drop.png`
  - `templates/tappyfowl.png`
  - `templates/unity-iap.png`
  - `templates/cat-attack.png`
  - `templates/mintcaster.png`
  - `tw-icons/marketplace.png`
  - `templates/marketplace.png`
  - `templates/nft-gallery.png`
  - `landingpage/white-logo.png`
  - `templates/expo-starter.png`
  - `templates/next-starter.png`
  - `templates/node-starter.png`
  - `templates/thirdweb-eth.png`
  - `templates/vite-starter.png`
  - `landingpage/marketplace.png`
  - `templates/unity-pioneer.png`
  - `templates/web3-warriors.png`
  - `add-contract/marketplace.png`
  - `templates/nft-gated-site.png`
  - `templates/unity-take-flight.png`
  - `templates/unity-blockventure.png`
  - `templates/phygital-experience.png`
  - `solutions-pages/gaming/marketplace.png`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 12-20-_tool-2810_remove_unused_assets_from_dashboard branch from 2755784 to 3d6e2a2 Compare December 19, 2024 22:59
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 19, 2024 22:59 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 19, 2024 22:59 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 19, 2024 22:59 Inactive
@graphite-app graphite-app bot merged commit 3d6e2a2 into main Dec 19, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 12-20-_tool-2810_remove_unused_assets_from_dashboard branch December 19, 2024 23:07
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 19, 2024 23:07 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui December 19, 2024 23:07 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 December 19, 2024 23:07 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@jakubkrehel jakubkrehel Awaiting requested review from jakubkrehel

Assignees

@MananTank MananTank

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls