Skip to content

Conversation

@0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Dec 27, 2024

Closes TOOL-2863


PR-Codex overview

This PR focuses on simplifying the OTP login process in the in-app-wallet functionality by removing the canRetry variable and associated logic, encouraging a retry mechanism through exception handling instead.

Detailed summary

  • Removed canRetry from LoginWithOtp method calls.
  • Simplified OTP login logic by eliminating conditional checks for retrying.
  • Added comments to suggest using try-catch for handling OTP failures.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@0xFirekeeper 0xFirekeeper added merge-queue Adds the pull request to Graphite's merge queue. hotfix This pull request should be prioritized in the merge queue. Portal Involves changes to the Portal (docs) codebase. labels Dec 27, 2024
@0xFirekeeper 0xFirekeeper requested review from a team and jakubkrehel as code owners December 27, 2024 18:03
@linear
Copy link

linear bot commented Dec 27, 2024

@changeset-bot
Copy link

changeset-bot bot commented Dec 27, 2024

⚠️ No Changeset found

Latest commit: 1556615

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 6:45pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Dec 27, 2024 6:45pm
thirdweb-www ⬜️ Skipped (Inspect) Dec 27, 2024 6:45pm
wallet-ui ⬜️ Skipped (Inspect) Dec 27, 2024 6:45pm

Copy link
Member Author

0xFirekeeper commented Dec 27, 2024

Merge activity

  • Dec 27, 1:03 PM EST: The merge label 'hotfix' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 27, 1:43 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 27, 1:48 PM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 27, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@codecov
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.53%. Comparing base (7293dfa) to head (1556615).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5843   +/-   ##
=======================================
  Coverage   54.53%   54.53%           
=======================================
  Files        1105     1105           
  Lines       59332    59332           
  Branches     4924     4924           
=======================================
  Hits        32354    32354           
  Misses      26258    26258           
  Partials      720      720           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 7293dfa
packages 52.02% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 27, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.02 KB (0%) 901 ms (0%) 831 ms (+49.39% 🔺) 1.8 s
thirdweb (cjs) 110.76 KB (0%) 2.3 s (0%) 1.5 s (+13.65% 🔺) 3.7 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 103 ms (+26.14% 🔺) 215 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 22 ms (-3.94% 🔽) 32 ms
thirdweb/react (minimal + tree-shaking) 19.12 KB (0%) 383 ms (0%) 191 ms (+6.66% 🔺) 573 ms

Closes TOOL-2863

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on simplifying the OTP login process in the `InAppWallet` by removing the `canRetry` variable and related conditional logic, providing a more straightforward approach for handling OTP submissions.

### Detailed summary
- Removed the `canRetry` variable from the `LoginWithOtp` method calls.
- Simplified the OTP login logic by eliminating the retry checks.
- Added comments to indicate where to implement error handling and retries if needed.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@0xFirekeeper 0xFirekeeper force-pushed the firekeeper/docs-otp-fix branch from 853e170 to 1556615 Compare December 27, 2024 18:43
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 27, 2024 18:43 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 27, 2024 18:43 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 27, 2024 18:43 Inactive
@graphite-app graphite-app bot merged commit 1556615 into main Dec 27, 2024
32 checks passed
@graphite-app graphite-app bot deleted the firekeeper/docs-otp-fix branch December 27, 2024 18:48
@vercel vercel bot temporarily deployed to Production – wallet-ui December 27, 2024 18:48 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 27, 2024 18:48 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www December 27, 2024 18:48 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotfix This pull request should be prioritized in the merge queue. merge-queue Adds the pull request to Graphite's merge queue. Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants