[SDK] Feature: Adds `deploySmartAccount` and re-adds 1271 signatures #5845

gregfromstl · 2024-12-27T20:45:19Z

PR-Codex overview

This PR introduces the deploySmartAccount function to facilitate the deployment of smart accounts and updates the handling of signatures for already deployed accounts to use ERC-1271 signatures.

Detailed summary

Added deploySmartAccount function for deploying smart accounts.
Updated createWallet to include connection with smart wallets.
Refactored decodeError, decodeFunctionData, and decodeFunctionResult to use ox__Abi.
Enhanced error handling in verifyHash and verifyEip1271Signature.
Updated tests to validate the new deployment and signature features.

The following files were skipped due to too many changes: pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

linear · 2024-12-27T20:45:22Z

TOOL-2837 SDK: Smart Accounts use 6492 even when already deployed

changeset-bot · 2024-12-27T20:45:23Z

🦋 Changeset detected

Latest commit: 720f290

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
thirdweb	Minor
@thirdweb-dev/wagmi-adapter	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2024-12-27T20:45:23Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 7, 2025 2:07am
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 7, 2025 2:07am
thirdweb-www	❌ Failed (Inspect)			Jan 7, 2025 2:07am
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 7, 2025 2:07am

graphite-app · 2024-12-27T20:45:26Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

github-actions · 2024-12-27T20:49:21Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	45.31 KB (+0.71% 🔺)	907 ms (+0.71% 🔺)	1.8 s (-61.53% 🔽)	2.7 s
thirdweb (cjs)	114.8 KB (+3.61% 🔺)	2.3 s (+3.61% 🔺)	2.9 s (-66.48% 🔽)	5.2 s
thirdweb (minimal + tree-shaking)	5.58 KB (0%)	112 ms (0%)	104 ms (-75.04% 🔽)	215 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	28 ms (-76.06% 🔽)	38 ms
thirdweb/react (minimal + tree-shaking)	19.13 KB (+0.23% 🔺)	383 ms (+0.23% 🔺)	312 ms (-67.51% 🔽)	695 ms

codecov · 2024-12-27T20:51:24Z

Codecov Report

Attention: Patch coverage is 81.94444% with 26 lines in your changes missing coverage. Please review.

Project coverage is 54.56%. Comparing base (7293dfa) to head (4a5b4b4).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/thirdweb/src/wallets/smart/lib/signing.ts	79.36%	26 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5845      +/-   ##
==========================================
+ Coverage   54.53%   54.56%   +0.03%     
==========================================
  Files        1105     1105              
  Lines       59332    59409      +77     
  Branches     4924     4931       +7     
==========================================
+ Hits        32354    32414      +60     
- Misses      26258    26274      +16     
- Partials      720      721       +1

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 7293dfa
packages	`52.06% <81.94%> (+0.04%)`	⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines	Coverage Δ
packages/thirdweb/src/auth/verify-hash.ts	`72.82% <100.00%> (+2.03%)`	⬆️
packages/thirdweb/src/wallets/create-wallet.ts	`26.48% <ø> (ø)`
packages/thirdweb/src/wallets/smart/index.ts	`56.54% <100.00%> (+0.22%)`	⬆️
...ackages/thirdweb/src/wallets/smart/smart-wallet.ts	`78.43% <ø> (ø)`
packages/thirdweb/src/wallets/smart/types.ts	`69.04% <ø> (ø)`
packages/thirdweb/src/wallets/smart/lib/signing.ts	`85.65% <79.36%> (-1.50%)`	⬇️

... and 4 files with indirect coverage changes

jnsdls

conflicts, otherwise LGTM

joaquim-verges · 2025-01-04T00:35:31Z

packages/thirdweb/src/auth/verify-hash.ts

    return hexToBool(result);
-  } catch (err) {
-    console.error("Error verifying ERC-6492 signature", err);
+  } catch {


What was the actual issue here?

6492 should automatically use 1271 if the account is already deployed, the deployed check happens inside the universal validator contract.

We shouldn't need to force it manually ever

joaquim-verges · 2025-01-05T23:23:00Z

packages/thirdweb/src/auth/verify-hash.ts

+      contract,
+    });
+    return result === EIP_1271_MAGIC_VALUE;
+  } catch {


Generally really want to log something for the dev to understand why the sig was not valid, same with the catch above

joaquim-verges · 2025-01-05T23:23:32Z

packages/thirdweb/src/wallets/smart/lib/signing.ts

-  if (!deployTx) {
-    throw new Error("Create account override not provided");
+  if (options.eagerDeployment) {
+    await forceDeploySmartAccount({


You should only do this if the account is not deployed yet

…ven-when-already-deployed

socket-security · 2025-01-07T00:01:59Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@chakra-ui/[email protected]	Transitive: environment, filesystem, network, shell, unsafe	`+132`	3.2 MB	segunadebayo
npm/@chakra-ui/[email protected]	Transitive: environment	`+39`	7.76 MB	segunadebayo
npm/@hookform/[email protected]	None	`0`	711 kB	bluebill1049, jorisre, kotarella1110
npm/@radix-ui/[email protected]	None	`+35`	1.65 MB	andy-hook, benoitgrelard, chancestrickland, ...3 more
npm/@radix-ui/[email protected]	None	`+20`	905 kB	chancestrickland
npm/@radix-ui/[email protected]	None	`+31`	1.29 MB	andy-hook, benoitgrelard, chancestrickland, ...3 more
npm/@radix-ui/[email protected]	None	`+35`	1.54 MB	chancestrickland
npm/@walletconnect/[email protected]	None	`+9`	403 kB	gancho_walletconnect
npm/[email protected]	filesystem Transitive: environment	`+35`	3.93 MB	rafaelrozon, yannbf
npm/[email protected]	network Transitive: environment	`+8`	18.5 MB	ricmoo
npm/[email protected]	Transitive: environment, eval, filesystem, network, shell, unsafe	`+594`	102 MB	brentvatne
npm/[email protected]	None	`0`	111 kB	guilhermerodz
npm/[email protected]	Transitive: environment	`+10`	917 kB	chayimischayim, ioredis-robot, luin
npm/[email protected]	Transitive: environment	`+80`	2.62 MB	wooorm

🚮 Removed packages: npm/@chakra-ui/[email protected], npm/@chakra-ui/[email protected], npm/@hookform/[email protected], npm/@radix-ui/[email protected], npm/@radix-ui/[email protected], npm/@radix-ui/[email protected], npm/@radix-ui/[email protected], npm/@walletconnect/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

gregfromstl requested review from a team as code owners December 27, 2024 20:45

github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Dec 27, 2024

github-actions bot assigned gregfromstl Dec 27, 2024

vercel bot deployed to Preview – wallet-ui December 27, 2024 20:46 View deployment

vercel bot deployed to Preview – thirdweb_playground December 27, 2024 20:47 View deployment

vercel bot deployed to Preview – docs-v2 December 27, 2024 20:52 View deployment

vercel bot deployed to Preview – thirdweb-www December 27, 2024 20:54 View deployment

gregfromstl force-pushed the greg/tool-2837-sdk-smart-accounts-use-6492-even-when-already-deployed branch from 61f9bbc to 4a5b4b4 Compare December 27, 2024 21:13

vercel bot deployed to Preview – wallet-ui December 27, 2024 21:16 View deployment

vercel bot deployed to Preview – thirdweb_playground December 27, 2024 21:17 View deployment

vercel bot deployed to Preview – docs-v2 December 27, 2024 21:22 View deployment

vercel bot deployed to Preview – thirdweb-www December 27, 2024 21:24 View deployment

jnsdls approved these changes Jan 4, 2025

View reviewed changes

joaquim-verges reviewed Jan 4, 2025

View reviewed changes

joaquim-verges reviewed Jan 5, 2025

View reviewed changes

fix: Adds 1271 signatures and force deployment function

f4678cd

gregfromstl force-pushed the greg/tool-2837-sdk-smart-accounts-use-6492-even-when-already-deployed branch from 4a5b4b4 to f4678cd Compare January 6, 2025 05:35

gregfromstl changed the title ~~[SDK] Feature: Adds eagerDeployment on smart account creation~~ [SDK] Feature: Adds deploySmartAccount and re-adds 1271 signatures Jan 6, 2025

vercel bot deployed to Preview – wallet-ui January 6, 2025 05:38 View deployment

vercel bot deployed to Preview – thirdweb_playground January 6, 2025 05:39 View deployment

0xFirekeeper approved these changes Jan 6, 2025

View reviewed changes

Merge branch 'main' into greg/tool-2837-sdk-smart-accounts-use-6492-e…

ce0a301

…ven-when-already-deployed

gregfromstl force-pushed the greg/tool-2837-sdk-smart-accounts-use-6492-even-when-already-deployed branch from 3664a2e to ce0a301 Compare January 7, 2025 00:00

vercel bot deployed to Preview – wallet-ui January 7, 2025 00:03 View deployment

vercel bot deployed to Preview – thirdweb_playground January 7, 2025 00:04 View deployment

vercel bot deployed to Preview – docs-v2 January 7, 2025 00:10 View deployment

fix(sdk): ox cjs imports

7846be4

gregfromstl force-pushed the greg/tool-2837-sdk-smart-accounts-use-6492-even-when-already-deployed branch from c9a7120 to 7846be4 Compare January 7, 2025 00:17

vercel bot deployed to Preview – wallet-ui January 7, 2025 00:27 View deployment

vercel bot deployed to Preview – thirdweb_playground January 7, 2025 00:28 View deployment

vercel bot had a problem deploying to Preview – docs-v2 January 7, 2025 00:34 Failure

gregfromstl force-pushed the greg/tool-2837-sdk-smart-accounts-use-6492-even-when-already-deployed branch from 5f9ec1a to d6f4727 Compare January 7, 2025 00:43

vercel bot deployed to Preview – wallet-ui January 7, 2025 00:46 View deployment

vercel bot deployed to Preview – thirdweb_playground January 7, 2025 00:46 View deployment

vercel bot deployed to Preview – docs-v2 January 7, 2025 00:51 View deployment

vercel bot had a problem deploying to Preview – thirdweb-www January 7, 2025 00:54 Failure

gregfromstl force-pushed the greg/tool-2837-sdk-smart-accounts-use-6492-even-when-already-deployed branch from d6f4727 to 11aa29f Compare January 7, 2025 01:38

vercel bot had a problem deploying to Preview – thirdweb_playground January 7, 2025 01:40 Failure

vercel bot had a problem deploying to Preview – wallet-ui January 7, 2025 01:40 Failure

vercel bot had a problem deploying to Preview – docs-v2 January 7, 2025 01:40 Failure

vercel bot had a problem deploying to Preview – thirdweb-www January 7, 2025 01:48 Failure

fix(sdk): smart account transactions on non-original chain

720f290

gregfromstl force-pushed the greg/tool-2837-sdk-smart-accounts-use-6492-even-when-already-deployed branch from 11aa29f to 720f290 Compare January 7, 2025 01:56

vercel bot deployed to Preview – wallet-ui January 7, 2025 01:59 View deployment

vercel bot deployed to Preview – thirdweb_playground January 7, 2025 01:59 View deployment

vercel bot deployed to Preview – docs-v2 January 7, 2025 02:04 View deployment

vercel bot had a problem deploying to Preview – thirdweb-www January 7, 2025 02:07 Failure

gregfromstl merged commit b058f68 into main Jan 7, 2025
26 of 28 checks passed

gregfromstl deleted the greg/tool-2837-sdk-smart-accounts-use-6492-even-when-already-deployed branch January 7, 2025 02:12

jnsdls mentioned this pull request Jan 7, 2025

Version Packages #5901

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SDK] Feature: Adds `deploySmartAccount` and re-adds 1271 signatures #5845

[SDK] Feature: Adds `deploySmartAccount` and re-adds 1271 signatures #5845

Uh oh!

gregfromstl commented Dec 27, 2024 •

edited by pr-codex bot

Loading

Uh oh!

linear bot commented Dec 27, 2024

Uh oh!

changeset-bot bot commented Dec 27, 2024 •

edited

Loading

Uh oh!

vercel bot commented Dec 27, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Dec 27, 2024

Uh oh!

github-actions bot commented Dec 27, 2024 •

edited

Loading

Uh oh!

codecov bot commented Dec 27, 2024 •

edited

Loading

Uh oh!

jnsdls left a comment

Uh oh!

joaquim-verges Jan 4, 2025

Uh oh!

joaquim-verges Jan 5, 2025

Uh oh!

joaquim-verges Jan 5, 2025

Uh oh!

socket-security bot commented Jan 7, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[SDK] Feature: Adds deploySmartAccount and re-adds 1271 signatures #5845

[SDK] Feature: Adds deploySmartAccount and re-adds 1271 signatures #5845

Uh oh!

Conversation

gregfromstl commented Dec 27, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Uh oh!

linear bot commented Dec 27, 2024

Uh oh!

changeset-bot bot commented Dec 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel bot commented Dec 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Dec 27, 2024

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Dec 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Dec 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jnsdls left a comment

Choose a reason for hiding this comment

Uh oh!

joaquim-verges Jan 4, 2025

Choose a reason for hiding this comment

Uh oh!

joaquim-verges Jan 5, 2025

Choose a reason for hiding this comment

Uh oh!

joaquim-verges Jan 5, 2025

Choose a reason for hiding this comment

Uh oh!

socket-security bot commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[SDK] Feature: Adds `deploySmartAccount` and re-adds 1271 signatures #5845

[SDK] Feature: Adds `deploySmartAccount` and re-adds 1271 signatures #5845

gregfromstl commented Dec 27, 2024 •

edited by pr-codex bot

Loading

changeset-bot bot commented Dec 27, 2024 •

edited

Loading

vercel bot commented Dec 27, 2024 •

edited

Loading

github-actions bot commented Dec 27, 2024 •

edited

Loading

codecov bot commented Dec 27, 2024 •

edited

Loading

socket-security bot commented Jan 7, 2025 •

edited

Loading