Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Dec 27, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR updates the environment variable VALID_ISSUE_PREFIXES in the .github/workflows/issue.yml file to include additional prefixes for issue validation.

Detailed summary

  • Modified VALID_ISSUE_PREFIXES from "CORE|TOOL" to "CORE|TOOL|NEB|INFRA" to allow for new issue prefixes NEB and INFRA.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Dec 27, 2024

@changeset-bot
Copy link

changeset-bot bot commented Dec 27, 2024

⚠️ No Changeset found

Latest commit: 860eddf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 9:22pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 9:22pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 9:22pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 9:22pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 27, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@codecov
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.52%. Comparing base (71eaf8f) to head (860eddf).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5847   +/-   ##
=======================================
  Coverage   54.52%   54.52%           
=======================================
  Files        1105     1105           
  Lines       59332    59332           
  Branches     4921     4921           
=======================================
  Hits        32349    32349           
  Misses      26263    26263           
  Partials      720      720           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 71eaf8f
packages 52.01% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.07 KB (0%) 902 ms (0%) 2.8 s (+17.51% 🔺) 3.7 s
thirdweb (cjs) 110.94 KB (0%) 2.3 s (0%) 5.4 s (+9.9% 🔺) 7.6 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 428 ms (+99.93% 🔺) 540 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 104 ms (-43.99% 🔽) 114 ms
thirdweb/react (minimal + tree-shaking) 19.12 KB (0%) 383 ms (0%) 596 ms (+38.6% 🔺) 978 ms

@gregfromstl gregfromstl merged commit 3e1bb53 into main Jan 2, 2025
33 checks passed
@gregfromstl gregfromstl deleted the greg/tool-2867-ci-add-all-teams-to-js-linear-tags branch January 2, 2025 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants