[TOOL-2876] Improve Transaction error toast messages #5853

MananTank · 2024-12-30T14:19:16Z

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR introduces a new notification system for various transaction actions within the NFT and token management components. It replaces toast notifications with a more structured useTxNotifications hook, enhancing user feedback during transactions.

Detailed summary

Added useTxNotifications to several components for transaction notifications.
Replaced toast notifications with onSuccess and onError methods from useTxNotifications.
Updated LazyMintNftForm, AirdropTab, NftMint, NFTClaimButton, NFTMintForm, SharedMetadataForm, UpdateNftMetadata, TokenAirdropForm, TokenClaimButton, CreateListingsForm to improve user feedback during transactions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

linear · 2024-12-30T14:19:19Z

TOOL-2876 Improve transaction error messages

vercel · 2024-12-30T14:19:20Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 31, 2024 10:28pm

3 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	Dec 31, 2024 10:28pm
thirdweb_playground	⬜️ Skipped (Inspect)	Dec 31, 2024 10:28pm
wallet-ui	⬜️ Skipped (Inspect)	Dec 31, 2024 10:28pm

MananTank · 2024-12-30T14:19:39Z

[TOOL-2876] Improve Transaction error toast messages #5853 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

.../app/(dashboard)/(chain)/[chain_id]/[contractAddress]/(marketplace)/components/list-form.tsx

codecov · 2024-12-30T14:20:53Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.18%. Comparing base (84d3dc4) to head (7bb7107).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5853   +/-   ##
=======================================
  Coverage   55.18%   55.18%           
=======================================
  Files        1123     1123           
  Lines       59611    59611           
  Branches     5031     5031           
=======================================
  Hits        32895    32895           
  Misses      25996    25996           
  Partials      720      720

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 84d3dc4
packages	`52.83% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

github-actions · 2024-12-30T14:22:52Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	45.09 KB (0%)	902 ms (0%)	311 ms (+114.54% 🔺)	1.3 s
thirdweb (cjs)	110.84 KB (0%)	2.3 s (0%)	436 ms (+41.62% 🔺)	2.7 s
thirdweb (minimal + tree-shaking)	5.58 KB (0%)	112 ms (0%)	120 ms (+1022.95% 🔺)	232 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	22 ms (+116.24% 🔺)	32 ms
thirdweb/react (minimal + tree-shaking)	19.12 KB (0%)	383 ms (0%)	89 ms (+72.3% 🔺)	472 ms

graphite-app · 2024-12-31T22:18:02Z

Merge activity

Dec 31, 5:18 PM EST: A user added this pull request to the Graphite merge queue.
Dec 31, 5:29 PM EST: A user merged this pull request with the Graphite merge queue.

## Problem solved Short description of the bug fixed or feature added  --- ## PR-Codex overview This PR focuses on enhancing user feedback for NFT and token transactions by integrating `useTxNotifications` for success and error notifications across various components. ### Detailed summary - Added `useTxNotifications` to multiple components for transaction feedback. - Replaced toast notifications with `onSuccess` and `onError` methods from `useTxNotifications`. - Updated success and error messages for lazy minting, airdropping, minting, claiming, and listing NFTs/tokens. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

changeset-bot · 2024-12-31T22:18:38Z

⚠️ No Changeset found

Latest commit: 7bb7107

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel bot temporarily deployed to Preview – docs-v2 December 30, 2024 14:19 Inactive

vercel bot temporarily deployed to Preview – wallet-ui December 30, 2024 14:19 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground December 30, 2024 14:19 Inactive

MananTank marked this pull request as ready for review December 30, 2024 14:19

MananTank requested review from a team and jakubkrehel as code owners December 30, 2024 14:19

github-actions bot assigned MananTank Dec 30, 2024

github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 30, 2024

graphite-app bot reviewed Dec 30, 2024

View reviewed changes

.../app/(dashboard)/(chain)/[chain_id]/[contractAddress]/(marketplace)/components/list-form.tsx Show resolved Hide resolved

vercel bot deployed to Preview – thirdweb-www December 30, 2024 14:28 View deployment

jnsdls approved these changes Dec 31, 2024

View reviewed changes

MananTank force-pushed the 12-30-_tool-2876_improve_transaction_error_toast_messages branch from 76d2ddd to 7bb7107 Compare December 31, 2024 22:18

vercel bot temporarily deployed to Preview – docs-v2 December 31, 2024 22:18 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground December 31, 2024 22:18 Inactive

vercel bot temporarily deployed to Preview – wallet-ui December 31, 2024 22:18 Inactive

vercel bot deployed to Preview – thirdweb-www December 31, 2024 22:28 View deployment

graphite-app bot merged commit 7bb7107 into main Dec 31, 2024
32 checks passed

graphite-app bot deleted the 12-30-_tool-2876_improve_transaction_error_toast_messages branch December 31, 2024 22:29

vercel bot temporarily deployed to Production – wallet-ui December 31, 2024 22:29 Inactive

vercel bot temporarily deployed to Production – docs-v2 December 31, 2024 22:29 Inactive

vercel bot temporarily deployed to Production – thirdweb_playground December 31, 2024 22:29 Inactive

vercel bot deployed to Production – thirdweb-www December 31, 2024 22:37 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[TOOL-2876] Improve Transaction error toast messages #5853

[TOOL-2876] Improve Transaction error toast messages #5853

Uh oh!

MananTank commented Dec 30, 2024 •

edited by pr-codex bot

Loading

Uh oh!

linear bot commented Dec 30, 2024

Uh oh!

vercel bot commented Dec 30, 2024 •

edited

Loading

Uh oh!

MananTank commented Dec 30, 2024

Uh oh!

Uh oh!

codecov bot commented Dec 30, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Dec 30, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Dec 31, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Dec 31, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[TOOL-2876] Improve Transaction error toast messages #5853

[TOOL-2876] Improve Transaction error toast messages #5853

Uh oh!

Conversation

MananTank commented Dec 30, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem solved

PR-Codex overview

Detailed summary

Uh oh!

linear bot commented Dec 30, 2024

Uh oh!

vercel bot commented Dec 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MananTank commented Dec 30, 2024

How to use the Graphite Merge Queue

Uh oh!

Uh oh!

codecov bot commented Dec 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Dec 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

graphite-app bot commented Dec 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

changeset-bot bot commented Dec 31, 2024

⚠️ No Changeset found

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MananTank commented Dec 30, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Dec 30, 2024 •

edited

Loading

codecov bot commented Dec 30, 2024 •

edited

Loading

github-actions bot commented Dec 30, 2024 •

edited

Loading

graphite-app bot commented Dec 31, 2024 •

edited

Loading