-
Notifications
You must be signed in to change notification settings - Fork 619
[Portal] Fix: Add erc20Value clarity to buyFromListing #5854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Portal] Fix: Add erc20Value clarity to buyFromListing #5854
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5854 +/- ##
=======================================
Coverage 55.18% 55.18%
=======================================
Files 1123 1123
Lines 59611 59611
Branches 5030 5031 +1
=======================================
Hits 32895 32895
Misses 25996 25996
Partials 720 720
*This pull request uses carry forward flags. Click here to find out more.
|
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR adds documentation to the
buyFromListingfunction, clarifying the behavior when using the function with Pay.Detailed summary
buyFromListingwith Pay, theerc20Valueis automatically set to the listing currency.