Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Dec 30, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR adds documentation to the buyFromListing function, clarifying the behavior when using the function with Pay.

Detailed summary

  • Added a comment explaining that when using buyFromListing with Pay, the erc20Value is automatically set to the listing currency.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners December 30, 2024 17:36
@linear
Copy link

linear bot commented Dec 30, 2024

@changeset-bot
Copy link

changeset-bot bot commented Dec 30, 2024

⚠️ No Changeset found

Latest commit: 740faf5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 5:36pm
thirdweb_playground 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 5:36pm
thirdweb-www 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 5:36pm
wallet-ui 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 5:36pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 30, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Dec 30, 2024
@gregfromstl gregfromstl merged commit fdf3d5b into main Dec 30, 2024
9 of 13 checks passed
@gregfromstl gregfromstl deleted the greg/tool-2880-portal-clarity-erc20-value-on-buyfromlisting-docs branch December 30, 2024 17:36
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.09 KB (0%) 902 ms (0%) 465 ms (+32.21% 🔺) 1.4 s
thirdweb (cjs) 110.84 KB (0%) 2.3 s (0%) 1.1 s (-12.28% 🔽) 3.3 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 106 ms (+37.06% 🔺) 218 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 22 ms (-30.94% 🔽) 32 ms
thirdweb/react (minimal + tree-shaking) 19.12 KB (0%) 383 ms (0%) 148 ms (+29.67% 🔺) 531 ms

@codecov
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.18%. Comparing base (31d11fa) to head (740faf5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5854   +/-   ##
=======================================
  Coverage   55.18%   55.18%           
=======================================
  Files        1123     1123           
  Lines       59611    59611           
  Branches     5030     5031    +1     
=======================================
  Hits        32895    32895           
  Misses      25996    25996           
  Partials      720      720           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 31d11fa
packages 52.83% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...arketplace/direct-listings/write/buyFromListing.ts 84.78% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants