[Dashboard] Enhance NFT Reveal feature #5862

kien-ngo · 2024-12-31T06:56:42Z

TOOL-2730
TOOL-2733
TOOL-2738

[x] Dont show Reveal-button if nothing to reveal
[x] Dont allow to select batches that were revealed already
[x] Show UI for the un-revealed. metadata

PR-Codex overview

This PR updates the nfts/components/reveal-button.tsx file to enhance the NFT reveal button's functionality and user experience. It introduces checks for batch reveal status and integrates a tooltip for better user feedback.

Detailed summary

Updated the documentation link in next-env.d.ts.
Added ToolTipLabel import in reveal-button.tsx.
Implemented a check to return null if no batches are available.
Added logic to display a tooltip and disabled button when all batches are revealed.
Disabled option in the select dropdown for revealed batches.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

changeset-bot · 2024-12-31T06:56:46Z

⚠️ No Changeset found

Latest commit: 8136ec9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2024-12-31T06:56:46Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 1, 2025 3:23am

3 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	Jan 1, 2025 3:23am
thirdweb_playground	⬜️ Skipped (Inspect)	Jan 1, 2025 3:23am
wallet-ui	⬜️ Skipped (Inspect)	Jan 1, 2025 3:23am

kien-ngo · 2024-12-31T06:56:58Z

[Dashboard] Enhance NFT Reveal feature #5862 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codecov · 2024-12-31T06:57:54Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.18%. Comparing base (7bb7107) to head (8136ec9).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5862   +/-   ##
=======================================
  Coverage   55.18%   55.18%           
=======================================
  Files        1123     1123           
  Lines       59611    59611           
  Branches     5031     5031           
=======================================
  Hits        32895    32895           
  Misses      25996    25996           
  Partials      720      720

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 7bb7107
packages	`52.83% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

...d/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/components/reveal-button.tsx

github-actions · 2024-12-31T07:03:04Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	45.09 KB (0%)	902 ms (0%)	2.7 s (-23.54% 🔽)	3.6 s
thirdweb (cjs)	110.84 KB (0%)	2.3 s (0%)	8 s (+10.65% 🔺)	10.2 s
thirdweb (minimal + tree-shaking)	5.58 KB (0%)	112 ms (0%)	387 ms (-8.23% 🔽)	499 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	69 ms (+26.26% 🔺)	79 ms
thirdweb/react (minimal + tree-shaking)	19.12 KB (0%)	383 ms (0%)	585 ms (-17.5% 🔽)	967 ms

graphite-app · 2025-01-01T03:14:30Z

Merge activity

Dec 31, 10:14 PM EST: A user added this pull request to the Graphite merge queue.
Dec 31, 10:23 PM EST: A user merged this pull request with the Graphite merge queue.

TOOL-2730 TOOL-2733 TOOL-2738 [x] Dont show Reveal-button if nothing to reveal [x] Dont allow to select batches that were revealed already [x] Show UI for the un-revealed. metadata  --- ## PR-Codex overview This PR updates the `nfts/components/reveal-button.tsx` file to enhance the NFT reveal functionality by adding a tooltip and handling cases for revealed batches. It also modifies a comment in `next-env.d.ts` to point to the correct documentation link. ### Detailed summary - Updated documentation link in `next-env.d.ts`. - Imported `ToolTipLabel` in `nfts/components/reveal-button.tsx`. - Added a check to return `null` if no batches are available. - Implemented logic to display a tooltip and disabled button when all batches are revealed. - Disabled options in the select dropdown for revealed batches. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

vercel bot temporarily deployed to Preview – wallet-ui December 31, 2024 06:56 Inactive

vercel bot temporarily deployed to Preview – docs-v2 December 31, 2024 06:56 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground December 31, 2024 06:56 Inactive

github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 31, 2024

kien-ngo changed the title ds [Dashboard] Enhance NFT Reveal feature Dec 31, 2024

kien-ngo marked this pull request as ready for review December 31, 2024 06:58

kien-ngo requested review from a team and jakubkrehel as code owners December 31, 2024 06:58

graphite-app bot reviewed Dec 31, 2024

View reviewed changes

...d/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/components/reveal-button.tsx Outdated Show resolved Hide resolved

kien-ngo force-pushed the kien/enhance-nft-reveal-exp branch from 2880bbe to 18a86d0 Compare December 31, 2024 06:59

vercel bot temporarily deployed to Preview – wallet-ui December 31, 2024 06:59 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground December 31, 2024 06:59 Inactive

vercel bot temporarily deployed to Preview – docs-v2 December 31, 2024 06:59 Inactive

vercel bot deployed to Preview – thirdweb-www December 31, 2024 07:11 View deployment

jnsdls approved these changes Dec 31, 2024

View reviewed changes

kien-ngo force-pushed the kien/enhance-nft-reveal-exp branch from 18a86d0 to 8136ec9 Compare January 1, 2025 03:15

vercel bot temporarily deployed to Preview – thirdweb_playground January 1, 2025 03:15 Inactive

vercel bot temporarily deployed to Preview – wallet-ui January 1, 2025 03:15 Inactive

vercel bot temporarily deployed to Preview – docs-v2 January 1, 2025 03:15 Inactive

vercel bot deployed to Preview – thirdweb-www January 1, 2025 03:23 View deployment

graphite-app bot merged commit 8136ec9 into main Jan 1, 2025
32 checks passed

graphite-app bot deleted the kien/enhance-nft-reveal-exp branch January 1, 2025 03:23

vercel bot temporarily deployed to Production – thirdweb_playground January 1, 2025 03:23 Inactive

vercel bot temporarily deployed to Production – docs-v2 January 1, 2025 03:23 Inactive

vercel bot temporarily deployed to Production – wallet-ui January 1, 2025 03:23 Inactive

vercel bot deployed to Production – thirdweb-www January 1, 2025 03:30 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Dashboard] Enhance NFT Reveal feature #5862

[Dashboard] Enhance NFT Reveal feature #5862

Uh oh!

kien-ngo commented Dec 31, 2024 •

edited by pr-codex bot

Loading

Uh oh!

changeset-bot bot commented Dec 31, 2024 •

edited

Loading

Uh oh!

vercel bot commented Dec 31, 2024 •

edited

Loading

Uh oh!

kien-ngo commented Dec 31, 2024

Uh oh!

codecov bot commented Dec 31, 2024 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Dec 31, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Jan 1, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[Dashboard] Enhance NFT Reveal feature #5862

[Dashboard] Enhance NFT Reveal feature #5862

Uh oh!

Conversation

kien-ngo commented Dec 31, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Uh oh!

changeset-bot bot commented Dec 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

vercel bot commented Dec 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kien-ngo commented Dec 31, 2024

How to use the Graphite Merge Queue

Uh oh!

codecov bot commented Dec 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

github-actions bot commented Dec 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

graphite-app bot commented Jan 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kien-ngo commented Dec 31, 2024 •

edited by pr-codex bot

Loading

changeset-bot bot commented Dec 31, 2024 •

edited

Loading

vercel bot commented Dec 31, 2024 •

edited

Loading

codecov bot commented Dec 31, 2024 •

edited

Loading

github-actions bot commented Dec 31, 2024 •

edited

Loading

graphite-app bot commented Jan 1, 2025 •

edited

Loading