Skip to content

adds missing async to connect docs #5864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 31, 2024
Merged

adds missing async to connect docs #5864

merged 1 commit into from
Dec 31, 2024

Conversation

@nischitpra
Copy link
Contributor

@nischitpra nischitpra commented Dec 31, 2024 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on updating the connect function calls in various files to use an asynchronous arrow function instead of a regular function. This change enhances the handling of asynchronous operations during wallet connection.

Detailed summary

  • Changed await connect(() => { to await connect(async () => { in multiple files:
    • apps/portal/src/app/connect/in-app-wallet/custom-auth/configuration/page.mdx
    • apps/portal/src/app/connect/in-app-wallet/guides/build-your-own-ui/page.mdx
    • apps/portal/src/app/react/v5/in-app-wallet/build-your-own-ui/page.mdx
    • apps/portal/src/app/react/v5/in-app-wallet/get-started/page.mdx
    • apps/portal/src/app/react/v5/in-app-wallet/guides/build-your-own-ui/page.mdx
    • Other files in the same directory structure.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@nischitpra nischitpra added the merge-queue Adds the pull request to Graphite's merge queue. label Dec 31, 2024
@nischitpra nischitpra requested review from a team and jakubkrehel as code owners December 31, 2024 09:14
@changeset-bot
Copy link

changeset-bot bot commented Dec 31, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 84d3dc4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 6:51pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Dec 31, 2024 6:51pm
thirdweb-www ⬜️ Skipped (Inspect) Dec 31, 2024 6:51pm
wallet-ui ⬜️ Skipped (Inspect) Dec 31, 2024 6:51pm

@nischitpra Graphite App
Copy link
Contributor Author

nischitpra commented Dec 31, 2024 •
edited by graphite-app bot
Loading

Merge activity

  • Dec 31, 4:14 AM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 31, 1:50 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 31, 1:53 PM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 31, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Dec 31, 2024
@nischitpra nischitpra enabled auto-merge (squash) December 31, 2024 09:14
@codecov
Copy link

codecov bot commented Dec 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.18%. Comparing base (31d11fa) to head (84d3dc4).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5864   +/-   ##
=======================================
  Coverage   55.18%   55.18%           
=======================================
  Files        1123     1123           
  Lines       59611    59611           
  Branches     5030     5031    +1     
=======================================
  Hits        32895    32895           
  Misses      25996    25996           
  Partials      720      720
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 31d11fa
packages 52.83% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 31, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.09 KB (0%) 902 ms (0%) 916 ms (+14.53% 🔺) 1.9 s
thirdweb (cjs) 110.84 KB (0%) 2.3 s (0%) 1.7 s (-19.61% 🔽) 3.9 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 152 ms (+226.75% 🔺) 263 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 57 ms (+190.37% 🔺) 67 ms
thirdweb/react (minimal + tree-shaking) 19.12 KB (0%) 383 ms (0%) 224 ms (+26.3% 🔺) 607 ms

@nischitpra
adds missing async to connect docs (#5864)
84d3dc4 
<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on updating the `handleLogin` and `handlePostLogin` functions to use an `async` callback within the `connect` function, enhancing the handling of asynchronous operations in the in-app wallet connection process.

### Detailed summary
- Changed `connect(() => {...})` to `connect(async () => {...})` in multiple files.
- Updated `handlePostLogin` in `apps/portal/src/app/connect/in-app-wallet/custom-auth/configuration/page.mdx`.
- Updated `handleLogin` in various files:
  - `apps/portal/src/app/connect/in-app-wallet/guides/build-your-own-ui/page.mdx`
  - `apps/portal/src/app/react/v5/in-app-wallet/build-your-own-ui/page.mdx`
  - `apps/portal/src/app/react/v5/in-app-wallet/get-started/page.mdx`
  - Other instances in similar files.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 31, 2024 18:50 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 31, 2024 18:50 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 31, 2024 18:50 Inactive
@graphite-app graphite-app bot merged commit 84d3dc4 into main Dec 31, 2024
31 checks passed
@graphite-app graphite-app bot deleted the np/asyncFix branch December 31, 2024 18:53
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 31, 2024 18:53 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www December 31, 2024 18:53 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui December 31, 2024 18:53 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MananTank MananTank MananTank approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

@jakubkrehel jakubkrehel Awaiting requested review from jakubkrehel

Assignees

No one assigned

Labels

merge-queue Adds the pull request to Graphite's merge queue. Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nischitpra @MananTank