Skip to content

Conversation

@dirtycajunrice
Copy link
Contributor

@dirtycajunrice dirtycajunrice commented Jan 2, 2025


title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

How to test

Unit tests, playground, etc.


PR-Codex overview

This PR introduces the SocialIcon component in the icon.tsx file, allowing rendering of social provider icons. It also adds a corresponding test in icon.test.tsx to ensure the component renders correctly.

Detailed summary

  • Added SocialIcon component to icon.tsx for rendering social provider icons.
  • Introduced a test suite for SocialIcon in icon.test.tsx to verify image rendering.
  • Corrected a typo in the JSDoc comment regarding icon retrieval failure.
  • Simplified the fetchWalletImage function by directly returning the result.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@dirtycajunrice dirtycajunrice requested review from a team as code owners January 2, 2025 19:54
@vercel
Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 8:19pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 8:19pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 8:19pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 8:19pm

@changeset-bot
Copy link

changeset-bot bot commented Jan 2, 2025

⚠️ No Changeset found

Latest commit: 2537e46

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Jan 2, 2025
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.09 KB (0%) 902 ms (0%) 3 s (+4.66% 🔺) 3.9 s
thirdweb (cjs) 110.84 KB (0%) 2.3 s (0%) 6.8 s (+25.31% 🔺) 9 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 367 ms (-15.28% 🔽) 479 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 145 ms (+49.61% 🔺) 155 ms
thirdweb/react (minimal + tree-shaking) 19.12 KB (0%) 383 ms (0%) 636 ms (-34.35% 🔽) 1.1 s

@gregfromstl gregfromstl merged commit cd06b10 into main Jan 3, 2025
28 of 29 checks passed
@gregfromstl gregfromstl deleted the 01-02-expose_social_icons branch January 3, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants