[SDK] onTimeout for useAutoConnect | TOOL-2673 #5879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 810f319 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
kien-ngo
force-pushed
the
kien/useAutoConnect-throw-error-CNCT-2673
branch
from
ead15bb to
b4a8832
Compare
Contributor
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5879 +/- ##
==========================================
+ Coverage 55.19% 55.27% +0.07%
==========================================
Files 1123 1123
Lines 59617 59636 +19
Branches 5028 5041 +13
==========================================
+ Hits 32905 32961 +56
+ Misses 25992 25953 -39
- Partials 720 722 +2
*This pull request uses carry forward flags. Click here to find out more.
|
kien-ngo
changed the title
kien-ngo
force-pushed
the
kien/useAutoConnect-throw-error-CNCT-2673
branch
from
b4a8832 to
ac8ba1b
Compare
kien-ngo
changed the title
gregfromstl
approved these changes
Jan 3, 2025
gregfromstl
reviewed
Jan 3, 2025
Contributor
gregfromstl
left a comment
gregfromstl
left a comment
There was a problem hiding this comment.
Missing test coverage
kien-ngo
force-pushed
the
kien/useAutoConnect-throw-error-CNCT-2673
branch
from
ac8ba1b to
2972aad
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
packages/thirdweb/src/react/core/hooks/wallets/useAutoConnect.test.tsx
Outdated
Show resolved
Hide resolved
kien-ngo
force-pushed
the
kien/useAutoConnect-throw-error-CNCT-2673
branch
from
6326e45 to
7b85028
Compare
kien-ngo
force-pushed
the
kien/useAutoConnect-throw-error-CNCT-2673
branch
from
7b85028 to
448a80c
Compare
kien-ngo
force-pushed
the
kien/useAutoConnect-throw-error-CNCT-2673
branch
from
448a80c to
d5a11bf
Compare
Contributor
Author
|
/release-pr |
Contributor
Merge activity
|
TOOL-2673
<!-- start pr-codex -->
---
## PR-Codex overview
This PR introduces an `onTimeout` callback to the `useAutoConnect` hook, enhancing its functionality by allowing users to define custom behavior when a connection attempt times out. It also includes tests for the new feature and refactors some wallet connection logic.
### Detailed summary
- Added `onTimeout` callback to `useAutoConnect`.
- Updated `useAutoConnectCore` to handle wallet connections with the new `onTimeout` feature.
- Refactored `handleWalletConnection` function to improve clarity.
- Added unit tests for `getUrlToken` covering various scenarios.
- Updated test configurations for better matching of test files.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
kien-ngo
force-pushed
the
kien/useAutoConnect-throw-error-CNCT-2673
branch
from
d5a11bf to
810f319
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TOOL-2673
PR-Codex overview
This PR introduces an
onTimeoutcallback to theuseAutoConnectfunctionality in thethirdwebpackage, enhancing connection management. Additionally, it adds tests for thegetUrlTokenfunction and updates thevitestconfiguration for testing.Detailed summary
onTimeoutcallback touseAutoConnect.types.tsto includeonTimeoutin the connection options.useAutoConnectCoreto handle timeout scenarios.getUrlTokencovering various cases.vitest.config.tsto include all test files.