Skip to content

[TOOL-2890] Dashboard: Fix spelling issues #5891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2025
Merged

[TOOL-2890] Dashboard: Fix spelling issues #5891

merged 1 commit into from
Jan 6, 2025

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Jan 6, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on correcting typos, improving comments, and enhancing code clarity across various components in the application.

Detailed summary

  • Fixed typos in text and comments throughout several files.
  • Updated class names for consistency.
  • Corrected function and variable names for clarity.
  • Enhanced comments to improve understanding of the code.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Jan 6, 2025

TOOL-2890 Small Typo on Modular Account Factory

@vercel
Copy link

vercel bot commented Jan 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 1:57pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 6, 2025 1:57pm
thirdweb_playground ⬜️ Skipped (Inspect) Jan 6, 2025 1:57pm
wallet-ui ⬜️ Skipped (Inspect) Jan 6, 2025 1:57pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 6, 2025 13:23 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 6, 2025 13:23 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 6, 2025 13:23 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Jan 6, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 18ef10b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MananTank MananTank marked this pull request as ready for review January 6, 2025 13:23
@MananTank MananTank requested review from a team and jakubkrehel as code owners January 6, 2025 13:23
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 6, 2025
@MananTank Graphite App
Copy link
Member Author

MananTank commented Jan 6, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45 KB (0%) 900 ms (0%) 2.7 s (-28.4% 🔽) 3.6 s
thirdweb (cjs) 110.81 KB (0%) 2.3 s (0%) 6 s (-7.11% 🔽) 8.2 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 396 ms (-13.17% 🔽) 508 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 54 ms (+16.67% 🔺) 64 ms
thirdweb/react (minimal + tree-shaking) 19.09 KB (0%) 382 ms (0%) 621 ms (-35.44% 🔽) 1.1 s

@codecov
Copy link

codecov bot commented Jan 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.36%. Comparing base (0a7beb8) to head (18ef10b).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5891   +/-   ##
=======================================
  Coverage   55.36%   55.36%           
=======================================
  Files        1123     1123           
  Lines       59642    59642           
  Branches     5056     5056           
=======================================
  Hits        33023    33023           
  Misses      25895    25895           
  Partials      724      724
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 0a7beb8
packages 53.06% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

kien-ngo
kien-ngo approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@kien-ngo kien-ngo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge one very nice ser

LGTM

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 6, 2025 •
edited
Loading

Merge activity

@MananTank
[TOOL-2890] Dashboard: Fix spelling issues (#5891)
18ef10b 
<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on fixing typos, improving comments, and enhancing code readability across various files in the project.

### Detailed summary
- Corrected typos in text labels (e.g., `Manange` to `Manage`, `Comunity` to `Community`).
- Improved comments for clarity (e.g., `Fix colors on autofilled inputs` to `Fix colors on auto-filled inputs`).
- Standardized variable names (e.g., `dispalyName` to `displayName`).
- Enhanced consistency in formatting (e.g., `balancesisPending` to `balancesIsPending`).
- Fixed minor grammatical issues in comments and strings throughout the code.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 01-06-_tool-2890_dashboard_fix_spelling_issues branch from 6420438 to 18ef10b Compare January 6, 2025 13:54
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 6, 2025 13:54 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 6, 2025 13:54 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 6, 2025 13:54 Inactive
@graphite-app graphite-app bot merged commit 18ef10b into main Jan 6, 2025
31 checks passed
@graphite-app graphite-app bot deleted the 01-06-_tool-2890_dashboard_fix_spelling_issues branch January 6, 2025 13:58
@vercel vercel bot temporarily deployed to Production – docs-v2 January 6, 2025 13:58 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui January 6, 2025 13:58 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground January 6, 2025 13:58 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakubkrehel jakubkrehel Awaiting requested review from jakubkrehel

1 more reviewer

@kien-ngo kien-ngo kien-ngo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MananTank MananTank

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @kien-ngo