[TOOL-2924] Catch error on fail-to-load metadata

[kien-ngo]

TOOL-2924

---

PR-Codex overview

This PR introduces changes to enhance type safety and improve the handling of optional values in the getBatchesToReveal function and the NFTRevealButton component.

Detailed summary

• In getBatchesToReveal.ts, placeholderMetadata is changed from NFTMetadata to NFTMetadata | undefined for better type handling.
• In getBatchesToReveal.ts, an error handling mechanism is added by returning undefined in the catch block.
• In reveal-button.tsx, the conditional rendering is simplified to always return the MinterOnly component, improving readability.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 6, 2025 10:15pm
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 6, 2025 10:15pm
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 6, 2025 10:15pm
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 6, 2025 10:15pm

[changeset-bot]

⚠️ No Changeset found

Latest commit: 9bc7884

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[kien-ngo]

• [TOOL-2924] Catch error on fail-to-load metadata #5892 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• merge-queue - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[linear]

TOOL-2924 [CORE-related] Reveal button is hidden if there's a broken batch

[github-actions]

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	45 KB (0%)	900 ms (0%)	2.7 s (-1.26% 🔽)	3.6 s
thirdweb (cjs)	110.81 KB (0%)	2.3 s (0%)	8.5 s (+30.67% 🔺)	10.7 s
thirdweb (minimal + tree-shaking)	5.58 KB (0%)	112 ms (0%)	414 ms (+22.21% 🔺)	526 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	145 ms (+47.13% 🔺)	155 ms
thirdweb/react (minimal + tree-shaking)	19.09 KB (0%)	382 ms (0%)	1.4 s (+106.86% 🔺)	1.8 s

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.37%. Comparing base (6bbfc4d) to head (9bc7884).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5892      +/-   ##
==========================================
+ Coverage   55.34%   55.37%   +0.02%     
==========================================
  Files        1124     1123       -1     
  Lines       59670    59642      -28     
  Branches     5054     5056       +2     
==========================================
- Hits        33025    33024       -1     
+ Misses      25921    25894      -27     
  Partials      724      724              

Flag	Coverage Δ		*Carryforward flag
legacy_packages	65.68% <ø> (ø)		Carriedforward from 6bbfc4d
packages	53.06% <100.00%> (+0.02%)	⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines	Coverage Δ
...ions/erc721/lazyMinting/read/getBatchesToReveal.ts	80.95% <100.00%> (ø)

... and 5 files with indirect coverage changes

[graphite-app]

Merge activity

• Jan 6, 4:57 PM EST: A user added this pull request to the Graphite merge queue.
• Jan 6, 5:03 PM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Vercel – docs-v2').
• Jan 6, 5:21 PM EST: A user added this pull request to the Graphite merge queue.
• Jan 6, 5:22 PM EST: A user merged this pull request with the Graphite merge queue.