Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Jan 6, 2025

PR-Codex overview

This PR focuses on refining the handling of published contracts by filtering out duplicates based on version, ensuring that only the latest contract for each version is retained.

Detailed summary

  • Introduced publishedContracts to filter responses for fulfilled statuses.
  • Added logic to create uniquePublishedContracts that retains only the latest contract for each version.
  • Utilized findIndex to identify the first occurrence of each version in the list.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Jan 6, 2025

@changeset-bot
Copy link

changeset-bot bot commented Jan 6, 2025

⚠️ No Changeset found

Latest commit: b781e97

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 6, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review January 6, 2025 16:19
@MananTank MananTank requested review from a team and jakubkrehel as code owners January 6, 2025 16:19
@vercel
Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 7:15pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 6, 2025 7:15pm
thirdweb_playground ⬜️ Skipped (Inspect) Jan 6, 2025 7:15pm
wallet-ui ⬜️ Skipped (Inspect) Jan 6, 2025 7:15pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui January 6, 2025 16:19 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 6, 2025 16:19 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 6, 2025 16:19 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45 KB (0%) 900 ms (0%) 641 ms (+43.08% 🔺) 1.6 s
thirdweb (cjs) 110.81 KB (0%) 2.3 s (0%) 769 ms (-22.1% 🔽) 3 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 125 ms (+291.79% 🔺) 237 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 70 ms (+252.11% 🔺) 80 ms
thirdweb/react (minimal + tree-shaking) 19.09 KB (0%) 382 ms (0%) 171 ms (+96.53% 🔺) 553 ms

@MananTank MananTank force-pushed the 01-06-_tool-2764_dashboard_fix_published_contract_version_selector_with_duplicate_versions branch from b7bfa34 to 5a3f5af Compare January 6, 2025 16:25
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 6, 2025 16:26 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 6, 2025 16:26 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 6, 2025 16:26 Inactive
@codecov
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.36%. Comparing base (18ef10b) to head (5a3f5af).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5893   +/-   ##
=======================================
  Coverage   55.36%   55.36%           
=======================================
  Files        1123     1123           
  Lines       59642    59642           
  Branches     5056     5056           
=======================================
  Hits        33023    33023           
  Misses      25895    25895           
  Partials      724      724           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 18ef10b
packages 53.06% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 6, 2025

Merge activity

…uplicate versions (#5893)

<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on refining the contract fetching logic to ensure that only unique published contracts are returned, specifically keeping the latest version of each contract.

### Detailed summary
- Introduced a new variable `publishedContracts` to store fulfilled responses.
- Added logic to filter out duplicate contracts by version, keeping only the latest occurrence.
- Returned the filtered list of unique published contracts.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 01-06-_tool-2764_dashboard_fix_published_contract_version_selector_with_duplicate_versions branch from 5a3f5af to b781e97 Compare January 6, 2025 19:11
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 6, 2025 19:12 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 6, 2025 19:12 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 6, 2025 19:12 Inactive
@MananTank MananTank requested a review from jnsdls January 6, 2025 19:38
@jnsdls jnsdls merged commit 80e70f2 into main Jan 6, 2025
29 checks passed
@jnsdls jnsdls deleted the 01-06-_tool-2764_dashboard_fix_published_contract_version_selector_with_duplicate_versions branch January 6, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants