Skip to content

Conversation

@ElasticBottle
Copy link
Contributor

@ElasticBottle ElasticBottle commented Jan 8, 2025

https://linear.app/thirdweb/issue/TOOL-2988/update-docs-to-call-out-pregeneration-caveats


PR-Codex overview

This PR focuses on enhancing documentation and adding a new wallet option in the AuthList. It includes notes on ecosystem wallets and smart accounts, as well as guidance on generating smart wallet addresses.

Detailed summary

  • Added "backend" to the AuthList options in AuthList.tsx.
  • Included documentation notes regarding ecosystem wallets and account abstraction in ConnectEmbed.tsx and ConnectButton.tsx.
  • Introduced a warning callout in page.mdx about generating smart wallet addresses.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@ElasticBottle ElasticBottle requested review from a team as code owners January 8, 2025 11:46
@linear
Copy link

linear bot commented Jan 8, 2025

@changeset-bot
Copy link

changeset-bot bot commented Jan 8, 2025

⚠️ No Changeset found

Latest commit: c339803

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 6:17pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 6:17pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 6:17pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 6:17pm

@github-actions github-actions bot added Portal Involves changes to the Portal (docs) codebase. packages SDK Involves changes to the thirdweb SDK labels Jan 8, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 8, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.65 KB (0%) 913 ms (0%) 476 ms (+12.45% 🔺) 1.4 s
thirdweb (cjs) 115.43 KB (0%) 2.4 s (0%) 1000 ms (+13.2% 🔺) 3.4 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 173 ms (+196.62% 🔺) 285 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 18 ms (+3.52% 🔺) 28 ms
thirdweb/react (minimal + tree-shaking) 19.21 KB (0%) 385 ms (0%) 120 ms (+35.92% 🔺) 504 ms

@codecov
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.83%. Comparing base (a693958) to head (c339803).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5912      +/-   ##
==========================================
- Coverage   54.83%   54.83%   -0.01%     
==========================================
  Files        1141     1141              
  Lines       60903    60903              
  Branches     5128     5128              
==========================================
- Hits        33396    33394       -2     
- Misses      26781    26782       +1     
- Partials      726      727       +1     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from a693958
packages 52.47% <ø> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...b/src/react/web/ui/ConnectWallet/ConnectButton.tsx 49.01% <ø> (ø)
.../react/web/ui/ConnectWallet/Modal/ConnectEmbed.tsx 12.44% <ø> (ø)

... and 2 files with indirect coverage changes

@joaquim-verges joaquim-verges changed the title [Portal]]: update docs on pre-generation and account abstraction [Portal]: update docs on pre-generation and account abstraction Jan 9, 2025
@joaquim-verges joaquim-verges changed the title [Portal]: update docs on pre-generation and account abstraction [Portal] update docs on pre-generation and account abstraction Jan 9, 2025
@ElasticBottle ElasticBottle added the merge-queue Adds the pull request to Graphite's merge queue. label Jan 10, 2025
Copy link
Contributor Author

ElasticBottle commented Jan 10, 2025

Merge activity

  • Jan 9, 8:11 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 9, 8:11 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 9, 8:18 PM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Vercel – docs-v2').
  • Jan 13, 1:01 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 13, 1:17 PM EST: A user merged this pull request with the Graphite merge queue.

ElasticBottle added a commit that referenced this pull request Jan 10, 2025
https://linear.app/thirdweb/issue/TOOL-2988/update-docs-to-call-out-pregeneration-caveats

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing documentation and functionality related to wallet connections and smart accounts in the `thirdweb` library, particularly around ecosystem wallets and the use of smart wallet addresses.

### Detailed summary
- Added the `backend` option to the `AuthList` component in `AuthList.tsx`.
- Included a note regarding ecosystem wallets in `ConnectEmbed.tsx` and `ConnectButton.tsx`.
- Added a warning callout in `page.mdx` about using `predictSmartAccountAddress` for generating smart wallet addresses.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@ElasticBottle ElasticBottle force-pushed the winston/tool-2988-update-docs-to-call-out-pregeneration-caveats branch from ff02eab to fe87437 Compare January 10, 2025 01:12
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Jan 10, 2025
@ElasticBottle ElasticBottle added the merge-queue Adds the pull request to Graphite's merge queue. label Jan 13, 2025
https://linear.app/thirdweb/issue/TOOL-2988/update-docs-to-call-out-pregeneration-caveats

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing documentation and functionality related to wallet connections and smart accounts in the `thirdweb` library, particularly emphasizing account abstraction and the use of smart wallets.

### Detailed summary
- Added `backend` to the `AuthList` component in `AuthList.tsx`.
- Updated documentation in `ConnectEmbed.tsx` and `ConnectButton.tsx` regarding ecosystem wallets and account abstraction.
- Introduced a warning callout in `page.mdx` for generating smart wallet addresses using `predictSmartAccountAddress`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-queue Adds the pull request to Graphite's merge queue. packages Portal Involves changes to the Portal (docs) codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants