[SDK/Dashboard] Fix: Deploy specified version of published contracts #5923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Contributor
size-limit report 📦
|
MananTank
approved these changes
Jan 9, 2025
🦋 Changeset detectedLatest commit: 42a313f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kumaryash90
changed the title
kumaryash90
changed the title
joaquim-verges
approved these changes
Jan 9, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5923 +/- ##
==========================================
- Coverage 54.83% 54.81% -0.03%
==========================================
Files 1141 1141
Lines 60897 60903 +6
Branches 5126 5126
==========================================
- Hits 33393 33384 -9
- Misses 26778 26795 +17
+ Partials 726 724 -2
*This pull request uses carry forward flags. Click here to find out more.
|
kumaryash90
added
the
merge-queue
Member
Author
Merge activity
|
…5923) TOOL-3013 TOOL-3014 ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the deployment process for contracts in the `thirdweb` package, including changes to version handling and contract IDs. ### Detailed summary - Updated `version` handling in the `custom-contract.tsx` file. - Changed `contractId` from `"Forwarder"` to `"ForwarderEOAOnly"` in `deploy-pack.ts`. - Added `version` to the options in `deployMarketplaceContract`. - Modified `getAllDefaultConstructorParamsForImplementation` to use a dynamic `contractId`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
kumaryash90
force-pushed
the
yash/use-publish-version
branch
from
49dcfb7 to
42a313f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TOOL-3013
TOOL-3014
Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
How to test
Unit tests, playground, etc.
PR-Codex overview
This PR focuses on updating the deployment version and contract identifiers for various components in the
thirdweblibrary, ensuring proper version handling for published contracts.Detailed summary
versionhandling incustom-contract.tsx.contractIdfrom"Forwarder"to"ForwarderEOAOnly"indeploy-pack.ts.versiontoDeployMarketplaceContractOptionsindeploy-marketplace.ts.getAllDefaultConstructorParamsForImplementationto includecontractId.