Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Jan 10, 2025

Fixes: TOOL-3018


PR-Codex overview

This PR focuses on improving error handling in the executeTx function within the packages/thirdweb/src/wallets/smart/index.ts file by ensuring the isDeploying flag is reset after both successful transactions and errors.

Detailed summary

  • Wrapped the transaction logic in a try block to handle errors.
  • Moved the clearAccountDeploying call into a finally block to ensure it runs after both success and error scenarios.
  • Maintained the structure of the user operation creation and signing process.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 8:35am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 8:35am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 8:35am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 8:35am

@changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2025

🦋 Changeset detected

Latest commit: e322d7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Jan 10, 2025
@joaquim-verges joaquim-verges changed the title fix: Reset deploy flag on bundler errors [SDK] fix: Reset deploy flag on bundler errors Jan 10, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@linear
Copy link

linear bot commented Jan 10, 2025

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.65 KB (0%) 913 ms (0%) 2.5 s (-3.81% 🔽) 3.4 s
thirdweb (cjs) 115.43 KB (0%) 2.4 s (0%) 6.9 s (+22.22% 🔺) 9.2 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 679 ms (+52.96% 🔺) 791 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 100 ms (+18.77% 🔺) 110 ms
thirdweb/react (minimal + tree-shaking) 19.21 KB (0%) 385 ms (0%) 641 ms (-20.44% 🔽) 1.1 s

@codecov
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.83%. Comparing base (ba86d51) to head (e322d7a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5924   +/-   ##
=======================================
  Coverage   54.82%   54.83%           
=======================================
  Files        1141     1141           
  Lines       60894    60897    +3     
  Branches     5126     5126           
=======================================
+ Hits        33386    33393    +7     
+ Misses      26782    26778    -4     
  Partials      726      726           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from ba86d51
packages 52.47% <100.00%> (+0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
packages/thirdweb/src/wallets/smart/index.ts 57.10% <100.00%> (+0.32%) ⬆️

... and 3 files with indirect coverage changes

@joaquim-verges joaquim-verges merged commit 7fb5ce1 into main Jan 10, 2025
34 of 37 checks passed
@joaquim-verges joaquim-verges deleted the fix_Reset_deploy_flag_on_bundler_errors branch January 10, 2025 08:40
@jnsdls jnsdls mentioned this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants