-
Notifications
You must be signed in to change notification settings - Fork 619
[SDK] fix: Reset deploy flag on bundler errors #5924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: e322d7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5924 +/- ##
=======================================
Coverage 54.82% 54.83%
=======================================
Files 1141 1141
Lines 60894 60897 +3
Branches 5126 5126
=======================================
+ Hits 33386 33393 +7
+ Misses 26782 26778 -4
Partials 726 726
*This pull request uses carry forward flags. Click here to find out more.
|

Fixes: TOOL-3018
PR-Codex overview
This PR focuses on improving error handling in the
executeTxfunction within thepackages/thirdweb/src/wallets/smart/index.tsfile by ensuring theisDeployingflag is reset after both successful transactions and errors.Detailed summary
tryblock to handle errors.clearAccountDeployingcall into afinallyblock to ensure it runs after both success and error scenarios.