Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Jan 12, 2025

PR-Codex overview

This PR focuses on enhancing the user interface and functionality of the ChatPageContent, TransactionButton, and ExecuteTransactionCard components in the dashboard application. It introduces new styles, improves layout, and updates transaction handling.

Detailed summary

  • Added background color styles for .shiki elements in globals.css.
  • Updated variant prop in TransactionButton to include "default".
  • Modified layout and spacing in ChatSidebar and EmptyStateChatPageContent.
  • Enhanced ExecuteTransactionCard with new transaction handling logic.
  • Introduced ExecuteTransactionCardWithFallback component in Chats.
  • Updated Chats component to use ExecuteTransactionCardWithFallback.
  • Added new stories for ExecuteTransactionCard and Chats in Storybook.
  • Improved message handling and UI in the Chats component.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Jan 12, 2025

@changeset-bot
Copy link

changeset-bot bot commented Jan 12, 2025

⚠️ No Changeset found

Latest commit: 4745786

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2025 7:30pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 12, 2025 7:30pm
thirdweb_playground ⬜️ Skipped (Inspect) Jan 12, 2025 7:30pm
wallet-ui ⬜️ Skipped (Inspect) Jan 12, 2025 7:30pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 12, 2025 14:17 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 12, 2025 14:17 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 12, 2025 14:17 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 12, 2025
@MananTank MananTank marked this pull request as ready for review January 12, 2025 14:17
@MananTank MananTank requested review from a team as code owners January 12, 2025 14:17
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank changed the title [NEB-54] Update Transaction Button UI [NEB-54] Nebula: Update Transaction Button UI Jan 12, 2025
@MananTank MananTank changed the title [NEB-54] Nebula: Update Transaction Button UI [NEB-54] Nebula: Improved Transaction action UI Jan 12, 2025
@codecov
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.83%. Comparing base (3cb1ab9) to head (4745786).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5931   +/-   ##
=======================================
  Coverage   54.83%   54.83%           
=======================================
  Files        1141     1141           
  Lines       60903    60903           
  Branches     5128     5128           
=======================================
  Hits        33396    33396           
  Misses      26781    26781           
  Partials      726      726           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 3cb1ab9
packages 52.47% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.65 KB (0%) 913 ms (0%) 3.5 s (+21.95% 🔺) 4.4 s
thirdweb (cjs) 115.43 KB (0%) 2.4 s (0%) 7.1 s (+2.99% 🔺) 9.4 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 574 ms (+219.76% 🔺) 686 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 68 ms (-21.95% 🔽) 78 ms
thirdweb/react (minimal + tree-shaking) 19.21 KB (0%) 385 ms (0%) 873 ms (-2.73% 🔽) 1.3 s

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 12, 2025

Merge activity

@MananTank MananTank force-pushed the 01-12-_neb-54_update_transaction_button_ui branch from d9f4dcd to 4745786 Compare January 12, 2025 19:22
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 12, 2025 19:22 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 12, 2025 19:22 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 12, 2025 19:22 Inactive
@graphite-app graphite-app bot merged commit 4745786 into main Jan 12, 2025
32 checks passed
@graphite-app graphite-app bot deleted the 01-12-_neb-54_update_transaction_button_ui branch January 12, 2025 19:31
@vercel vercel bot temporarily deployed to Production – docs-v2 January 12, 2025 19:31 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground January 12, 2025 19:31 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui January 12, 2025 19:31 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants