Skip to content

[TOOL-3044] Remove static generation of changelog pages #5935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[TOOL-3044] Remove static generation of changelog pages #5935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions apps/portal/src/app/changelog/[slug]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import { cn } from "@/lib/utils";
import { notFound } from "next/navigation";
import ReactHtmlParser from "react-html-parser";
import { fetchChangeLogs, fetchPost } from "../ghost";
import { fetchPost } from "../ghost";
import "./styles.css";
import { ArrowLeft } from "lucide-react";
import Link from "next/link";
Expand Down Expand Up @@ -72,13 +72,3 @@ export default async function Page(props: {
</div>
);
}

export async function generateStaticParams() {
const changelogs = await fetchChangeLogs();

return changelogs.map((changelog) => {
return {
slug: changelog.slug,
};
});
}
2 changes: 1 addition & 1 deletion apps/portal/src/app/changelog/utils/transform.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export const transform: Transform = (node, index: number) => {
const level = Number.parseInt(node.name[1] || "");

return (
<Heading level={level} id="#" anchorClassName="mt-10">
<Heading level={level} anchorClassName="mt-10" id={undefined}>
{getChildren()}
</Heading>
);
Expand Down
2 changes: 1 addition & 1 deletion apps/portal/src/components/Document/Heading.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { Anchor } from "../ui/Anchor";

export function Heading(props: {
children: React.ReactNode;
id: string;
id: string | undefined;
level: number;
className?: string;
anchorClassName?: string;
Expand Down
2 changes: 1 addition & 1 deletion apps/portal/src/components/ui/Anchor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { cn } from "@/lib/utils";
import { Link as LinkIcon } from "lucide-react";

export function Anchor(props: {
id: string;
id: string | undefined;
children: React.ReactNode;
className?: string;
}) {
Expand Down
Loading