-
Notifications
You must be signed in to change notification settings - Fork 618
[TOOL-3046]: Do not show invalid string error if NFT description is undefined #5939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TOOL-3046]: Do not show invalid string error if NFT description is undefined #5939
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5939 +/- ##
=======================================
Coverage 54.85% 54.85%
=======================================
Files 1142 1142
Lines 60928 60928
Branches 5140 5140
=======================================
Hits 33424 33424
Misses 26777 26777
Partials 727 727
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
Merge activity
|
c4d0944 to
22dc493
Compare

PR-Codex overview
This PR improves the validation of the
descriptionfield in thenfts/components/table.tsxfile by ensuring that the check for a valid string also accounts for the possibility ofcell.valuebeingnullorundefined.Detailed summary
Cellfunction to check ifcell.valueexists before verifying its type.descriptionfield.