Skip to content

track ratelimit only on creation #5950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 15, 2025
Merged

track ratelimit only on creation #5950

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
111a095
track ratelimit only on creation
nischitpra Jan 14, 2025
91f07d8
check fix
nischitpra Jan 14, 2025
c711c18
remove 2x limit window leeway
nischitpra Jan 14, 2025
d077061
minor change
nischitpra Jan 15, 2025
f2754a1
tests update
nischitpra Jan 15, 2025
ff54bd9
Merge branch 'main' into np/ratelimit_fix
nischitpra Jan 15, 2025
45c046f
minor version bump
nischitpra Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions packages/service-utils/src/core/rateLimit/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,15 @@ export async function rateLimit(args: {
limitPerSecond * sampleRate * RATE_LIMIT_WINDOW_SECONDS;

if (requestCount > limitPerWindow) {
// Report rate limit hits.
if (project?.id) {
await updateRateLimitedAt(project.id, serviceConfig);
/**
* Report rate limit hits.
* Only track rate limit when its hit for the first time.
* Not waiting for tracking to complete as user doesn't need to wait.
*/
if (requestCount <= limitPerWindow + 1 && project?.id) {
updateRateLimitedAt(project.id, serviceConfig).catch(() => {
// no-op
});
}

// Reject requests when they've exceeded 2x the rate limit.
Expand Down
Loading