[TOOL-2473] Dashboard: Update RPC method analytics chart to show % values #5954

MananTank · 2025-01-14T21:07:47Z

PR-Codex overview

This PR focuses on enhancing the RpcMethodBarChartCardUI component by improving data handling and display logic, including the addition of new RPC methods, updating the tooltip functionality, and refining the data visualization for clarity and usability.

Detailed summary

Modified valueFormatter to accept an additional payLoad parameter.
Increased gap in the tooltip layout from gap-2 to gap-5.
Changed the condition for displaying item value to check for undefined.
Introduced a random chance to make data empty in the chart.
Added multiple new RPC methods to the commonMethods array.
Updated BadgeContainer labels for clarity.
Enhanced data processing logic to better handle method counts and empty states.
Refined tooltip formatting to display percentage values.
Updated chart configuration to reflect changes in displayed methods.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

linear · 2025-01-14T21:07:50Z

TOOL-2473 Update RPC Methods analytics bar chart to show percentage instead of absolute values

changeset-bot · 2025-01-14T21:07:51Z

⚠️ No Changeset found

Latest commit: 0fdfb8a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-01-14T21:07:52Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 14, 2025 9:53pm

3 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	Jan 14, 2025 9:53pm
thirdweb_playground	⬜️ Skipped (Inspect)	Jan 14, 2025 9:53pm
wallet-ui	⬜️ Skipped (Inspect)	Jan 14, 2025 9:53pm

MananTank · 2025-01-14T21:08:07Z

[TOOL-2473] Dashboard: Update RPC method analytics chart to show % values #5954 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

...team_slug]/[project_slug]/components/RpcMethodBarChartCard/RpcMethodBarChartCard.stories.tsx

...team/[team_slug]/[project_slug]/components/RpcMethodBarChartCard/RpcMethodBarChartCardUI.tsx

codecov · 2025-01-14T21:09:11Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.96%. Comparing base (46bf17c) to head (0fdfb8a).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5954   +/-   ##
=======================================
  Coverage   54.96%   54.96%           
=======================================
  Files        1145     1145           
  Lines       60996    60996           
  Branches     5156     5156           
=======================================
  Hits        33528    33528           
  Misses      26740    26740           
  Partials      728      728

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 46bf17c
packages	`52.64% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

...team/[team_slug]/[project_slug]/components/RpcMethodBarChartCard/RpcMethodBarChartCardUI.tsx

github-actions · 2025-01-14T21:16:59Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	46.68 KB (0%)	934 ms (0%)	3.5 s (+38.11% 🔺)	4.4 s
thirdweb (cjs)	116.72 KB (0%)	2.4 s (0%)	7.8 s (+18.04% 🔺)	10.2 s
thirdweb (minimal + tree-shaking)	5.59 KB (0%)	112 ms (0%)	224 ms (+15.46% 🔺)	335 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	103 ms (+100.37% 🔺)	113 ms
thirdweb/react (minimal + tree-shaking)	19.24 KB (0%)	385 ms (0%)	728 ms (+32.34% 🔺)	1.2 s

...team/[team_slug]/[project_slug]/components/RpcMethodBarChartCard/RpcMethodBarChartCardUI.tsx

graphite-app · 2025-01-14T21:50:36Z

Merge activity

Jan 14, 4:50 PM EST: A user added this pull request to the Graphite merge queue.
Jan 14, 4:54 PM EST: A user merged this pull request with the Graphite merge queue.

…lues (#5954)  ## PR-Codex overview This PR focuses on enhancing the `RpcMethodBarChartCardUI` component by improving data handling, updating the `valueFormatter` function, and refining the chart display logic. It also introduces new RPC methods and adjusts the layout of the chart. ### Detailed summary - Updated `valueFormatter` in `chart.tsx` to accept a second parameter. - Changed the gap between elements in the chart tooltip from `gap-2` to `gap-5`. - Adjusted condition to check for `item.value` to `item.value !== undefined`. - Added randomness to the data generation logic to simulate empty data. - Introduced new RPC methods in the `commonMethods` array. - Updated the `BadgeContainer` labels for clarity on RPC methods displayed. - Enhanced data processing in `RpcMethodBarChartCardUI` for better method display. - Implemented a total count for methods in the chart data. - Updated the tooltip label formatter to use `formatDate`. - Modified the Y-axis configuration to remove unused properties. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

vercel bot temporarily deployed to Preview – docs-v2 January 14, 2025 21:07 Inactive

vercel bot temporarily deployed to Preview – wallet-ui January 14, 2025 21:07 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground January 14, 2025 21:07 Inactive

github-actions bot assigned MananTank Jan 14, 2025

github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 14, 2025

graphite-app bot reviewed Jan 14, 2025

View reviewed changes

...team_slug]/[project_slug]/components/RpcMethodBarChartCard/RpcMethodBarChartCard.stories.tsx Show resolved Hide resolved

...team/[team_slug]/[project_slug]/components/RpcMethodBarChartCard/RpcMethodBarChartCardUI.tsx Outdated Show resolved Hide resolved

MananTank marked this pull request as ready for review January 14, 2025 21:09

MananTank requested review from a team as code owners January 14, 2025 21:09

MananTank force-pushed the TOOL-2473 branch from c8718fa to 2e21e80 Compare January 14, 2025 21:10

vercel bot temporarily deployed to Preview – thirdweb_playground January 14, 2025 21:10 Inactive

vercel bot temporarily deployed to Preview – docs-v2 January 14, 2025 21:10 Inactive

vercel bot temporarily deployed to Preview – wallet-ui January 14, 2025 21:10 Inactive

graphite-app bot reviewed Jan 14, 2025

View reviewed changes

...team/[team_slug]/[project_slug]/components/RpcMethodBarChartCard/RpcMethodBarChartCardUI.tsx Outdated Show resolved Hide resolved

...team/[team_slug]/[project_slug]/components/RpcMethodBarChartCard/RpcMethodBarChartCardUI.tsx Outdated Show resolved Hide resolved

MananTank force-pushed the TOOL-2473 branch from 2e21e80 to a89efab Compare January 14, 2025 21:13

vercel bot temporarily deployed to Preview – docs-v2 January 14, 2025 21:13 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground January 14, 2025 21:13 Inactive

vercel bot temporarily deployed to Preview – wallet-ui January 14, 2025 21:13 Inactive

MananTank force-pushed the TOOL-2473 branch from a89efab to cdda662 Compare January 14, 2025 21:20

vercel bot temporarily deployed to Preview – thirdweb_playground January 14, 2025 21:20 Inactive

vercel bot temporarily deployed to Preview – wallet-ui January 14, 2025 21:20 Inactive

vercel bot temporarily deployed to Preview – docs-v2 January 14, 2025 21:20 Inactive

vercel bot deployed to Preview – thirdweb-www January 14, 2025 21:28 View deployment

gregfromstl approved these changes Jan 14, 2025

View reviewed changes

MananTank force-pushed the TOOL-2473 branch from cdda662 to e888f8a Compare January 14, 2025 21:42

vercel bot temporarily deployed to Preview – docs-v2 January 14, 2025 21:42 Inactive

vercel bot temporarily deployed to Preview – wallet-ui January 14, 2025 21:42 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground January 14, 2025 21:42 Inactive

graphite-app bot reviewed Jan 14, 2025

View reviewed changes

...team/[team_slug]/[project_slug]/components/RpcMethodBarChartCard/RpcMethodBarChartCardUI.tsx Show resolved Hide resolved

vercel bot deployed to Preview – thirdweb-www January 14, 2025 21:49 View deployment

MananTank force-pushed the TOOL-2473 branch from e888f8a to 0fdfb8a Compare January 14, 2025 21:51

vercel bot temporarily deployed to Preview – wallet-ui January 14, 2025 21:51 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground January 14, 2025 21:51 Inactive

vercel bot temporarily deployed to Preview – docs-v2 January 14, 2025 21:51 Inactive

vercel bot deployed to Preview – thirdweb-www January 14, 2025 21:53 View deployment

graphite-app bot merged commit 0fdfb8a into main Jan 14, 2025
31 checks passed

graphite-app bot deleted the TOOL-2473 branch January 14, 2025 21:54

vercel bot temporarily deployed to Production – wallet-ui January 14, 2025 21:54 Inactive

vercel bot temporarily deployed to Production – thirdweb_playground January 14, 2025 21:54 Inactive

vercel bot temporarily deployed to Production – docs-v2 January 14, 2025 21:54 Inactive

vercel bot deployed to Production – thirdweb-www January 14, 2025 22:02 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[TOOL-2473] Dashboard: Update RPC method analytics chart to show % values #5954

[TOOL-2473] Dashboard: Update RPC method analytics chart to show % values #5954

Uh oh!

MananTank commented Jan 14, 2025 •

edited by pr-codex bot

Loading

Uh oh!

linear bot commented Jan 14, 2025

Uh oh!

changeset-bot bot commented Jan 14, 2025 •

edited

Loading

Uh oh!

vercel bot commented Jan 14, 2025 •

edited

Loading

Uh oh!

MananTank commented Jan 14, 2025

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jan 14, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 14, 2025 •

edited

Loading

Uh oh!

Uh oh!

graphite-app bot commented Jan 14, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[TOOL-2473] Dashboard: Update RPC method analytics chart to show % values #5954

[TOOL-2473] Dashboard: Update RPC method analytics chart to show % values #5954

Uh oh!

Conversation

MananTank commented Jan 14, 2025 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Uh oh!

linear bot commented Jan 14, 2025

Uh oh!

changeset-bot bot commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

vercel bot commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MananTank commented Jan 14, 2025

How to use the Graphite Merge Queue

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

Uh oh!

graphite-app bot commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MananTank commented Jan 14, 2025 •

edited by pr-codex bot

Loading

changeset-bot bot commented Jan 14, 2025 •

edited

Loading

vercel bot commented Jan 14, 2025 •

edited

Loading

codecov bot commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

graphite-app bot commented Jan 14, 2025 •

edited

Loading