Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Jan 15, 2025


title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

How to test

Unit tests, playground, etc.


PR-Codex overview

This PR focuses on updating the handling of sponsored amounts in the TotalSponsoredChartCard and SponsoredTransactionsChartCard components. It replaces the calculation of sponsored amounts from a rounded value to the raw value, improving the accuracy of the data displayed.

Detailed summary

  • In TotalSponsoredChartCard.tsx:

    • Changed Math.round(stat.sponsoredUsd * 100) / 100 to stat.sponsoredUsd.
  • In SponsoredTransactionsChartCard.tsx:

    • Changed Math.round(stat.sponsoredUsd * 100) / 100 to stat.successful.
    • Updated volume calculation to use stat.successful instead of stat.sponsoredUsd.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners January 15, 2025 20:06
@linear
Copy link

linear bot commented Jan 15, 2025

@changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2025

⚠️ No Changeset found

Latest commit: 9aeb883

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 11:41pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 11:41pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 11:41pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 11:41pm

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 15, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 15, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.68 KB (0%) 934 ms (0%) 3.9 s (-0.4% 🔽) 4.9 s
thirdweb (cjs) 116.72 KB (0%) 2.4 s (0%) 5.9 s (-13.63% 🔽) 8.3 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 210 ms (-44.38% 🔽) 322 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 88 ms (-2.46% 🔽) 98 ms
thirdweb/react (minimal + tree-shaking) 19.24 KB (0%) 385 ms (0%) 956 ms (+42.67% 🔺) 1.4 s

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 15, 2025 20:10 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 15, 2025 20:10 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 15, 2025 20:10 Inactive
@gregfromstl gregfromstl force-pushed the greg/tool-3088-dashboard-fix-testnet-aa-transaction-count branch from d7394ed to a2608b7 Compare January 15, 2025 20:12
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 15, 2025 20:12 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 15, 2025 20:12 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 15, 2025 20:12 Inactive
@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Jan 15, 2025
Copy link
Contributor Author

gregfromstl commented Jan 15, 2025

Merge activity

  • Jan 15, 3:12 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 15, 3:12 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@codecov
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.82%. Comparing base (51a28c4) to head (9aeb883).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5958   +/-   ##
=======================================
  Coverage   54.82%   54.82%           
=======================================
  Files        1150     1150           
  Lines       61194    61194           
  Branches     5155     5155           
=======================================
  Hits        33549    33549           
  Misses      26918    26918           
  Partials      727      727           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 51a28c4
packages 52.47% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@gregfromstl gregfromstl merged commit 07a5c98 into main Jan 15, 2025
30 checks passed
@gregfromstl gregfromstl deleted the greg/tool-3088-dashboard-fix-testnet-aa-transaction-count branch January 15, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants