Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Jan 15, 2025


title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

How to test

Unit tests, playground, etc.


PR-Codex overview

This PR focuses on improving the structure of the test suite for verifying contract wallet signatures by adding a beforeAll hook to set up the smartAccount before tests run.

Detailed summary

  • Added beforeAll hook to initialize smartAccount before tests.
  • Changed the signature of the verifyContractWalletSignature test to remove the async keyword.
  • Added type import for Account from ../wallets/interfaces/wallet.js.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 11:34pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 11:34pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 11:34pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 11:34pm

@changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2025

⚠️ No Changeset found

Latest commit: e679914

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Jan 15, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges marked this pull request as ready for review January 15, 2025 23:27
@joaquim-verges joaquim-verges requested review from a team as code owners January 15, 2025 23:27
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.68 KB (0%) 934 ms (0%) 928 ms (+57.01% 🔺) 1.9 s
thirdweb (cjs) 116.72 KB (0%) 2.4 s (0%) 1.6 s (+30.83% 🔺) 3.9 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 343 ms (+253.33% 🔺) 455 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 178 ms (+319.27% 🔺) 188 ms
thirdweb/react (minimal + tree-shaking) 19.24 KB (0%) 385 ms (0%) 453 ms (+141.07% 🔺) 838 ms

@codecov
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.82%. Comparing base (51a28c4) to head (e679914).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5962      +/-   ##
==========================================
- Coverage   54.82%   54.82%   -0.01%     
==========================================
  Files        1150     1150              
  Lines       61194    61194              
  Branches     5155     5154       -1     
==========================================
- Hits        33549    33548       -1     
- Misses      26918    26919       +1     
  Partials      727      727              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 51a28c4
packages 52.47% <ø> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 2 files with indirect coverage changes

@joaquim-verges joaquim-verges merged commit a834199 into main Jan 16, 2025
33 of 36 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_test_Refactor_smart_wallet_signature_verification_tests branch January 16, 2025 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants