-
Notifications
You must be signed in to change notification settings - Fork 619
[SDK] test: Refactor smart wallet signature verification tests #5962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] test: Refactor smart wallet signature verification tests #5962
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5962 +/- ##
==========================================
- Coverage 54.82% 54.82% -0.01%
==========================================
Files 1150 1150
Lines 61194 61194
Branches 5155 5154 -1
==========================================
- Hits 33549 33548 -1
- Misses 26918 26919 +1
Partials 727 727
*This pull request uses carry forward flags. Click here to find out more. |

title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
How to test
Unit tests, playground, etc.
PR-Codex overview
This PR focuses on improving the structure of the test suite for verifying contract wallet signatures by adding a
beforeAllhook to set up thesmartAccountbefore tests run.Detailed summary
beforeAllhook to initializesmartAccountbefore tests.verifyContractWalletSignaturetest to remove theasynckeyword.Accountfrom../wallets/interfaces/wallet.js.