[TOOL-3096] React SDK: Fix NFT components not including contract address in queryKey #5966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 4ffcf30 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
MananTank
force-pushed
the
01-16-_tool-3096_react_sdk_fix_nft_components_not_including_contract_address_in_querykey
branch
from
379882b to
da9f1a5
Compare
gregfromstl
approved these changes
Jan 16, 2025
Contributor
size-limit report 📦
|
MananTank
force-pushed
the
01-16-_tool-3096_react_sdk_fix_nft_components_not_including_contract_address_in_querykey
branch
from
da9f1a5 to
b49676e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5966 +/- ##
=======================================
Coverage 54.81% 54.82%
=======================================
Files 1150 1150
Lines 61195 61200 +5
Branches 5153 5154 +1
=======================================
+ Hits 33545 33550 +5
Misses 26923 26923
Partials 727 727
*This pull request uses carry forward flags. Click here to find out more.
|
Contributor
Merge activity
|
gregfromstl
pushed a commit
that referenced
this pull request
Jan 16, 2025
…ess in queryKey (#5966) <!-- start pr-codex --> ## PR-Codex overview This PR focuses on improving the handling of NFT metadata by fixing issues with caching when multiple contracts share the same token ID. It updates various components to include the `contractAddress` in the query keys for better differentiation. ### Detailed summary - Added `contractAddress` to query keys in `getQueryKey` functions in `name.tsx`, `media.tsx`, and `description.tsx`. - Updated related tests in `name.test.tsx` and `media.test.tsx` to include `contractAddress`. - Fixed caching issue for NFT components with identical token IDs across contracts. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
gregfromstl
force-pushed
the
01-16-_tool-3096_react_sdk_fix_nft_components_not_including_contract_address_in_querykey
branch
from
b49676e to
7d2aa81
Compare
gregfromstl
pushed a commit
that referenced
this pull request
Jan 16, 2025
…ess in queryKey (#5966) <!-- start pr-codex --> ## PR-Codex overview This PR focuses on improving the handling of NFT metadata in components by ensuring that the `contractAddress` is included in the query keys. This change addresses issues with incorrect caching when rendering multiple contracts with the same token ID. ### Detailed summary - Added `contractAddress` to the query keys in `getQueryKey` functions for `NFTDescription`, `NFTName`, and `NFTMedia`. - Updated tests in `media.test.tsx` and `name.test.tsx` to include `contractAddress` when calling `getQueryKey`. - Fixed metadata display issues when multiple contracts with the same token ID are rendered. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
gregfromstl
force-pushed
the
01-16-_tool-3096_react_sdk_fix_nft_components_not_including_contract_address_in_querykey
branch
from
7d2aa81 to
f8f0bcb
Compare
gregfromstl
pushed a commit
that referenced
this pull request
Jan 16, 2025
…ess in queryKey (#5966) <!-- start pr-codex --> ## PR-Codex overview This PR focuses on fixing issues with NFT components not displaying the correct metadata when multiple contracts share the same token ID. It improves caching by including `contractAddress` in the query keys for NFT metadata retrieval. ### Detailed summary - Added `contractAddress` to query keys in `getQueryKey` functions for `NFTName`, `NFTMedia`, and `NFTDescription`. - Updated related queries in `name.tsx`, `media.tsx`, and `description.tsx` to use `contract.address`. - Enhanced tests in `name.test.tsx` and `media.test.tsx` to validate the inclusion of `contractAddress` in query keys. - Updated changelog to document the fix for metadata display issues. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
gregfromstl
force-pushed
the
01-16-_tool-3096_react_sdk_fix_nft_components_not_including_contract_address_in_querykey
branch
from
f8f0bcb to
1afab7e
Compare
…ess in queryKey (#5966) <!-- start pr-codex --> ## PR-Codex overview This PR focuses on improving the handling of NFT metadata in the `thirdweb` library by adding `contractAddress` to various query keys, which resolves issues with metadata caching when multiple contracts share the same token ID. ### Detailed summary - Added `contractAddress` to the query keys in `getQueryKey` functions for `NFTName`, `NFTMedia`, and `NFTDescription`. - Updated related queries to include `contractAddress`. - Fixed metadata display issues when rendering multiple contracts with the same token ID. - Enhanced tests in `name.test.tsx` and `media.test.tsx` to validate the new `contractAddress` parameter. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
MananTank
force-pushed
the
01-16-_tool-3096_react_sdk_fix_nft_components_not_including_contract_address_in_querykey
branch
from
ce313f9 to
4ffcf30
Compare
graphite-app
bot
deleted the
01-16-_tool-3096_react_sdk_fix_nft_components_not_including_contract_address_in_querykey
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on fixing the caching issue in NFT components that caused incorrect metadata display when multiple contracts had the same token ID. It introduces
contractAddressas a parameter in various functions to ensure proper data retrieval.Detailed summary
contractAddressto the query keys ingetQueryKeyfunctions forNFTName,NFTMedia, andNFTDescription.media.test.tsxandname.test.tsxto includecontractAddress.