Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Jan 16, 2025


title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

How to test

Unit tests, playground, etc.


PR-Codex overview

This PR focuses on adding support for the Lumia Testnet by including pre-EIP1559 gas values in the thirdweb package.

Detailed summary

  • Added an entry for Lumia Testnet with the gas value 1952959480 in the packages/thirdweb/src/gas/fee-data.ts file.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners January 16, 2025 18:08
@linear
Copy link

linear bot commented Jan 16, 2025

@changeset-bot
Copy link

changeset-bot bot commented Jan 16, 2025

🦋 Changeset detected

Latest commit: 86c8d5f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 6:19pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 6:19pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 6:19pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 6:19pm

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Jan 16, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 16, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.66 KB (-0.05% 🔽) 934 ms (-0.05% 🔽) 1.2 s (-24.98% 🔽) 2.2 s
thirdweb (cjs) 116.84 KB (+0.1% 🔺) 2.4 s (+0.1% 🔺) 4 s (+11.27% 🔺) 6.3 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 268 ms (+24.74% 🔺) 380 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 67 ms (+203.66% 🔺) 77 ms
thirdweb/react (minimal + tree-shaking) 19.24 KB (0%) 385 ms (0%) 400 ms (-10.45% 🔽) 785 ms

@codecov
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.83%. Comparing base (00f1d29) to head (86c8d5f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5967   +/-   ##
=======================================
  Coverage   54.82%   54.83%           
=======================================
  Files        1150     1150           
  Lines       61194    61195    +1     
  Branches     5153     5155    +2     
=======================================
+ Hits        33550    33554    +4     
+ Misses      26918    26914    -4     
- Partials      726      727    +1     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 00f1d29
packages 52.48% <100.00%> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
packages/thirdweb/src/gas/fee-data.ts 72.60% <100.00%> (+0.18%) ⬆️

... and 2 files with indirect coverage changes

@joaquim-verges joaquim-verges mentioned this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants