Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Jan 17, 2025

TOOL-3130


PR-Codex overview

This PR focuses on modifications within the supported-chains functionality of the pay module in the connect section of the portal application.

Detailed summary

  • Updated the logic for handling supported chains in the pay module.
  • Improved error handling when querying chain support.
  • Enhanced the user interface to better display supported chains.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners January 17, 2025 17:02
@changeset-bot
Copy link

changeset-bot bot commented Jan 17, 2025

⚠️ No Changeset found

Latest commit: 17374d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2025 7:06am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Jan 18, 2025 7:06am
thirdweb-www ⬜️ Skipped (Inspect) Jan 18, 2025 7:06am
wallet-ui ⬜️ Skipped (Inspect) Jan 18, 2025 7:06am

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 17, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@codecov
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.80%. Comparing base (79769d6) to head (17374d1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5975   +/-   ##
=======================================
  Coverage   54.80%   54.80%           
=======================================
  Files        1151     1151           
  Lines       61257    61257           
  Branches     5151     5151           
=======================================
  Hits        33571    33571           
  Misses      26959    26959           
  Partials      727      727           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 79769d6
packages 52.45% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 17, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.66 KB (0%) 934 ms (0%) 697 ms (+210.69% 🔺) 1.7 s
thirdweb (cjs) 116.84 KB (0%) 2.4 s (0%) 750 ms (-8.79% 🔽) 3.1 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 95 ms (+118.26% 🔺) 207 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 9 ms (-49.22% 🔽) 19 ms
thirdweb/react (minimal + tree-shaking) 19.24 KB (0%) 385 ms (0%) 176 ms (+117.43% 🔺) 560 ms

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Jan 17, 2025
Copy link
Contributor Author

gregfromstl commented Jan 17, 2025

Merge activity

  • Jan 17, 12:08 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 18, 1:58 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 18, 2:07 AM EST: A user merged this pull request with the Graphite merge queue.

@gregfromstl gregfromstl force-pushed the fix/supported-chains-page branch from 7e5673e to 17374d1 Compare January 18, 2025 06:59
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 18, 2025 06:59 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 18, 2025 06:59 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www January 18, 2025 06:59 Inactive
@graphite-app graphite-app bot merged commit 17374d1 into main Jan 18, 2025
32 checks passed
@graphite-app graphite-app bot deleted the fix/supported-chains-page branch January 18, 2025 07:07
@vercel vercel bot temporarily deployed to Production – wallet-ui January 18, 2025 07:07 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www January 18, 2025 07:07 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground January 18, 2025 07:07 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-queue Adds the pull request to Graphite's merge queue. Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants