Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Jan 17, 2025


title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

How to test

Unit tests, playground, etc.


PR-Codex overview

This PR introduces a SmartAccountAuthButton component for Ethereum authentication using smart accounts. It leverages the ConnectButton from thirdweb to manage user login state and integrates JWT handling in the SmartAccountAuthPreview component.

Detailed summary

  • Added SmartAccountAuthButton component in smart-account-auth-button.tsx.
  • Integrated Ethereum authentication methods: isLoggedIn, login, logout, and generatePayload.
  • Introduced SmartAccountAuthPreview to display JWT cookies in smart-account-auth.tsx.
  • Updated the main Page component to include SmartAccountAuth.
  • Created a new SmartAccountAuth function to render authentication UI and code example.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners January 17, 2025 19:14
@linear
Copy link

linear bot commented Jan 17, 2025

@changeset-bot
Copy link

changeset-bot bot commented Jan 17, 2025

⚠️ No Changeset found

Latest commit: 1b64d6e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 8:36pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 17, 2025 8:36pm
thirdweb-www ⬜️ Skipped (Inspect) Jan 17, 2025 8:36pm
wallet-ui ⬜️ Skipped (Inspect) Jan 17, 2025 8:36pm

@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Jan 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 17, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.66 KB (0%) 934 ms (0%) 280 ms (+51.06% 🔺) 1.3 s
thirdweb (cjs) 116.84 KB (0%) 2.4 s (0%) 515 ms (+4.84% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 66 ms (+189.71% 🔺) 178 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 13 ms (+38.44% 🔺) 23 ms
thirdweb/react (minimal + tree-shaking) 19.24 KB (0%) 385 ms (0%) 81 ms (+34.12% 🔺) 465 ms

@codecov
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.80%. Comparing base (f1afa3b) to head (1b64d6e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5979   +/-   ##
=======================================
  Coverage   54.80%   54.80%           
=======================================
  Files        1150     1150           
  Lines       61237    61237           
  Branches     5154     5154           
=======================================
  Hits        33559    33559           
  Misses      26950    26950           
  Partials      728      728           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from f1afa3b
packages 52.45% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Jan 17, 2025
Copy link
Contributor Author

gregfromstl commented Jan 17, 2025

Merge activity

  • Jan 17, 3:29 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 17, 3:34 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 17, 3:38 PM EST: A user merged this pull request with the Graphite merge queue.

@gregfromstl gregfromstl force-pushed the greg/tool-3138-cannot-use-siwe-smart-accounts-together-on-the-latest-sdk branch from 44af834 to 030521e Compare January 17, 2025 20:30
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 17, 2025 20:30 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 17, 2025 20:30 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www January 17, 2025 20:30 Inactive
---
title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
---

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.

## How to test
Unit tests, playground, etc.

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces a new smart account authentication feature in the `playground-web` application, allowing users to sign in using Ethereum. It adds a new component for the authentication button and integrates it into the main application page.

### Detailed summary
- Added `SmartAccountAuthButton` component for Ethereum authentication.
- Implemented `SmartAccountAuthPreview` to display JWT cookies.
- Updated `page.tsx` to include `SmartAccountAuth` section.
- Added a code example demonstrating the authentication button usage.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@gregfromstl gregfromstl force-pushed the greg/tool-3138-cannot-use-siwe-smart-accounts-together-on-the-latest-sdk branch from 030521e to 1b64d6e Compare January 17, 2025 20:35
@vercel vercel bot temporarily deployed to Preview – thirdweb-www January 17, 2025 20:35 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 17, 2025 20:35 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 17, 2025 20:35 Inactive
@graphite-app graphite-app bot merged commit 1b64d6e into main Jan 17, 2025
31 checks passed
@graphite-app graphite-app bot deleted the greg/tool-3138-cannot-use-siwe-smart-accounts-together-on-the-latest-sdk branch January 17, 2025 20:38
@vercel vercel bot temporarily deployed to Production – thirdweb-www January 17, 2025 20:38 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 January 17, 2025 20:38 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui January 17, 2025 20:38 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-queue Adds the pull request to Graphite's merge queue. Playground Changes involving the Playground codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants