Skip to content

Conversation

@0xwitty
Copy link

@0xwitty 0xwitty commented Jan 21, 2025

I noticed that the comment in the code wasn't accurate. The useCalculatedVersion property is added to the snapshot object, not the root of the configuration.

This update fixes the comment to better reflect where the change is applied.


PR-Codex overview

This PR updates the configuration for nightly changesets by enabling the useCalculatedVersion feature in the snapshot configuration.

Detailed summary

  • Changed comment from "// add useCalculatedVersion: true to the config" to "// enable useCalculatedVersion in the snapshot configuration".
  • Added useCalculatedVersion: true to the snapshot property in nightlyChangesetsConfig.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

corrected comment to reflect actual changes in useCalculatedVersion placement

Signed-off-by: witty <[email protected]>
@changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2025

⚠️ No Changeset found

Latest commit: 4624efb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 21, 2025

@0xwitty is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 21, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@0xwitty 0xwitty changed the title fix: corrected comment to reflect actual changes fix: corrected comment to reflect actual changes merge-queue Jan 21, 2025
@jnsdls
Copy link
Member

jnsdls commented Jan 22, 2025

thanks for the PR, not merging this however as the comment already adequately describes what is happening and if anything could simply be removed instead

@jnsdls jnsdls closed this Jan 22, 2025
@0xwitty
Copy link
Author

0xwitty commented Jan 23, 2025

thanks for the PR, not merging this however as the comment already adequately describes what is happening and if anything could simply be removed instead

jnsdls I understand your point, but I believe the updated comment provides more clarity, especially for new contributors who might not be familiar with the codebase. It explicitly points out where the useCalculatedVersion property is applied, which could prevent misunderstandings in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants