Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Jan 24, 2025

Fixes TOOL-3221


PR-Codex overview

This PR focuses on simplifying the in-app wallet login flow by modifying the logout process in the iframe-auth.ts file.

Detailed summary

  • Removed the conditional check for this.AuthQuerier in the logout method.
  • Directly calls this.localStorage.removeAuthCookie() and this.localStorage.removeWalletUserId() after removing the AuthQuerier logic.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 1:45am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 1:45am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 1:45am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 1:45am

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Jan 24, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@linear
Copy link

linear bot commented Jan 24, 2025

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.69 KB (0%) 934 ms (0%) 829 ms (+15.58% 🔺) 1.8 s
thirdweb (cjs) 116.89 KB (0%) 2.4 s (0%) 1.3 s (-0.78% 🔽) 3.6 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 200 ms (+241.08% 🔺) 312 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 47 ms (+149.51% 🔺) 57 ms
thirdweb/react (minimal + tree-shaking) 19.22 KB (0%) 385 ms (0%) 188 ms (+67.56% 🔺) 572 ms

@joaquim-verges joaquim-verges merged commit 5ad442c into main Jan 24, 2025
31 of 34 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_fix_Simplify_in-app_wallet_logout_flow branch January 24, 2025 01:49
@joaquim-verges joaquim-verges mentioned this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants