Skip to content

Conversation

@arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Jan 24, 2025

Also part of CORE-713.
This PR adds the changeset and fixes a build error.

PR-Codex overview

This PR focuses on updating the service-utils package by replacing the usage of client_id with project_id in the usage_v2 function.

Detailed summary

  • In the file packages/service-utils/src/node/usageV2.ts:
    • Replaced the line defining client_id with project_id:
      • From client_id: event.client_id to project_id: event.project_id

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@arcoraven arcoraven requested a review from a team as a code owner January 24, 2025 08:57
@changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2025

🦋 Changeset detected

Latest commit: 4df6479

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 9:01am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 9:01am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 9:01am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 9:01am

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 24, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@linear
Copy link

linear bot commented Jan 24, 2025

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.69 KB (0%) 934 ms (0%) 440 ms (+23.09% 🔺) 1.4 s
thirdweb (cjs) 116.89 KB (0%) 2.4 s (0%) 826 ms (-2.91% 🔽) 3.2 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 134 ms (+194% 🔺) 246 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 85 ms (+1190.08% 🔺) 95 ms
thirdweb/react (minimal + tree-shaking) 19.22 KB (0%) 385 ms (0%) 211 ms (+121.62% 🔺) 595 ms

@arcoraven arcoraven merged commit fb4d0a2 into main Jan 24, 2025
30 of 31 checks passed
@arcoraven arcoraven deleted the ph/usageV2ProjectId2 branch January 24, 2025 09:02
@joaquim-verges joaquim-verges mentioned this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants