Update page.mdx #6053
Update page.mdx #6053
Conversation
Signed-off-by: jmack33 <[email protected]>
|
|
@jmack33 is attempting to deploy a commit to the thirdweb Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
the
Portal
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| return CounterStorage.data(); | ||
| } | ||
| } | ||
| config.callbackFunctions = new CallbackFunction config.fallbackFunctions = new FallbackFunction ; |
There was a problem hiding this comment.
The array initialization syntax appears malformed. The correct syntax should be:
config.callbackFunctions = new CallbackFunction[](1);
config.fallbackFunctions = new FallbackFunction[](5);Based on the number of fallback functions defined below, the second array needs space for 5 elements.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
| config.callbackFunctions[0] = CallbackFunction( | ||
| this.beforeTransfer.selector | ||
| ); |
There was a problem hiding this comment.
The beforeTransfer callback is registered in getModuleConfig() but the function itself appears to be missing from the contract. This creates a potential runtime error since the selector references a non-existent function. Either implement the beforeTransfer function with the appropriate hook logic, or remove its registration from the callback configuration.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
|
Thanks |
1 participant
title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
How to test
Unit tests, playground, etc.
PR-Codex overview
This PR focuses on enhancing the
CounterModulecontract by introducing a newBOPTokenModulewith additional functionalities for managing token transfers, fees, and storage.Detailed summary
BOPTokenModuleinheriting fromModule.TokenStoragelibrary for managing token state.getModuleConfigto include new functionalities and storage access.CounterModuleimplementation details.