Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Jan 27, 2025


title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

How to test

Unit tests, playground, etc.


PR-Codex overview

This PR focuses on updating the thirdweb library, including type refinements, dependency updates, and the addition of a new abstract chain definition. It also improves address handling across various functions.

Detailed summary

  • Updated address type in ThirdwebContract to enforce a specific format.
  • Refined address handling using getAddress in multiple files.
  • Added new abstract chain definition in abstract.ts.
  • Incremented size limits in .size-limit.json.
  • Updated various dependencies, including next, @next/eslint-plugin-next, and viem.
  • Modified several functions to use getContract for consistency in contract handling.
  • Adjusted tests to accommodate changes in address handling.

The following files were skipped due to too many changes: pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 3:17am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 3:17am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 3:17am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 3:17am

@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2025

🦋 Changeset detected

Latest commit: 04c4da5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added Playground Changes involving the Playground codebase. packages SDK Involves changes to the thirdweb SDK labels Jan 27, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges changed the title update dependencies [SDK] update dependencies Jan 27, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review January 27, 2025 00:27
@joaquim-verges joaquim-verges requested review from a team as code owners January 27, 2025 00:27
@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.85 KB (+0.35% 🔺) 938 ms (+0.35% 🔺) 3 s (+10.06% 🔺) 3.9 s
thirdweb (cjs) 123.65 KB (+5.79% 🔺) 2.5 s (+5.79% 🔺) 8.6 s (+15.32% 🔺) 11.1 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 187 ms (-34.44% 🔽) 298 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 114 ms (+115.68% 🔺) 124 ms
thirdweb/react (minimal + tree-shaking) 19.08 KB (-0.72% 🔽) 382 ms (-0.72% 🔽) 940 ms (+3.42% 🔺) 1.4 s

@codecov
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 24 lines in your changes missing coverage. Please review.

Project coverage is 55.02%. Comparing base (eafaefe) to head (04c4da5).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...eb/src/contract/deployment/zksync/zkDeployProxy.ts 0.00% 7 Missing ⚠️
...rc/extensions/erc4337/account/isAccountDeployed.ts 14.28% 6 Missing ⚠️
...irdweb/src/utils/bytecode/resolveImplementation.ts 60.00% 4 Missing ⚠️
packages/thirdweb/src/wallets/injected/index.ts 0.00% 2 Missing ⚠️
packages/thirdweb/src/rpc/actions/eth_getLogs.ts 0.00% 1 Missing ⚠️
...kages/thirdweb/src/transaction/actions/simulate.ts 50.00% 1 Missing ⚠️
...b/src/utils/extensions/airdrop/hash-entry-erc20.ts 0.00% 1 Missing ⚠️
.../src/utils/extensions/airdrop/hash-entry-erc721.ts 0.00% 1 Missing ⚠️
...b/src/wallets/in-app/core/wallet/enclave-wallet.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6057      +/-   ##
==========================================
+ Coverage   55.01%   55.02%   +0.01%     
==========================================
  Files        1151     1152       +1     
  Lines       61250    61280      +30     
  Branches     5176     5181       +5     
==========================================
+ Hits        33694    33722      +28     
- Misses      26827    26830       +3     
+ Partials      729      728       -1     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from eafaefe
packages 52.72% <71.42%> (+0.02%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
packages/thirdweb/src/adapters/viem.ts 44.09% <100.00%> (ø)
packages/thirdweb/src/auth/verify-hash.ts 77.77% <100.00%> (+0.19%) ⬆️
.../thirdweb/src/chains/chain-definitions/abstract.ts 100.00% <100.00%> (ø)
...ages/thirdweb/src/contract/actions/get-bytecode.ts 100.00% <100.00%> (ø)
...kages/thirdweb/src/contract/actions/resolve-abi.ts 89.10% <100.00%> (ø)
packages/thirdweb/src/contract/contract.ts 100.00% <ø> (ø)
...ontract/deployment/zksync/zkDeployDeterministic.ts 45.71% <100.00%> (+1.59%) ⬆️
packages/thirdweb/src/event/actions/get-events.ts 73.84% <100.00%> (ø)
...c721/lazyMinting/helpers/hashDelayedRevealBatch.ts 100.00% <100.00%> (ø)
...hirdweb/src/react/web/ui/ConnectWallet/Blobbie.tsx 95.34% <ø> (ø)
... and 18 more

... and 3 files with indirect coverage changes

@joaquim-verges joaquim-verges force-pushed the 01-26-update_dependencies branch 2 times, most recently from 8574964 to b6caee9 Compare January 27, 2025 01:01
@joaquim-verges joaquim-verges force-pushed the 01-26-update_dependencies branch from b6caee9 to 61d6666 Compare January 27, 2025 01:39
@joaquim-verges joaquim-verges force-pushed the 01-26-update_dependencies branch from 61d6666 to f3db753 Compare January 27, 2025 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. Ecosystem Portal Involves changes to the Ecosystem Portal packages Playground Changes involving the Playground codebase. Portal Involves changes to the Portal (docs) codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants