Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Jan 27, 2025

PR-Codex overview

This PR introduces the onLogout function into the onboarding process and modifies the login page to handle user login and logout more effectively, ensuring proper screen transitions based on the user's connection status.

Detailed summary

  • Added onLogout prop to OnboardingUI and OnboardingGeneral components.
  • Implemented handleLogout function to call onLogout after logging out.
  • Enhanced PageContent with an onLogin function to manage onboarding and login states.
  • Used useEffect to handle screen state based on connection status.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 7:57pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 27, 2025 7:57pm
thirdweb_playground ⬜️ Skipped (Inspect) Jan 27, 2025 7:57pm
wallet-ui ⬜️ Skipped (Inspect) Jan 27, 2025 7:57pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui January 27, 2025 18:22 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 27, 2025 18:22 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 27, 2025 18:22 Inactive
@linear
Copy link

linear bot commented Jan 27, 2025

@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2025

⚠️ No Changeset found

Latest commit: 153651d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 27, 2025
@MananTank MananTank marked this pull request as ready for review January 27, 2025 18:22
@MananTank MananTank requested review from a team as code owners January 27, 2025 18:22
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.01%. Comparing base (8ba460b) to head (153651d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6061   +/-   ##
=======================================
  Coverage   55.01%   55.01%           
=======================================
  Files        1152     1152           
  Lines       61280    61280           
  Branches     5177     5177           
=======================================
  Hits        33716    33716           
  Misses      26834    26834           
  Partials      730      730           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 8ba460b
packages 52.71% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.85 KB (0%) 938 ms (0%) 423 ms (+56.07% 🔺) 1.4 s
thirdweb (cjs) 123.65 KB (0%) 2.5 s (0%) 974 ms (+2.39% 🔺) 3.5 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 80 ms (+159.55% 🔺) 192 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 31 ms (+186.17% 🔺) 41 ms
thirdweb/react (minimal + tree-shaking) 19.08 KB (0%) 382 ms (0%) 118 ms (+83.7% 🔺) 500 ms

useEffect(() => {
// if suddenly disconnected
if (connectionStatus !== "connected" && screen.id !== "login") {
setScreen({ id: "login" });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this safe?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - just making sure that you are never setting an onboarding screen if wallet is disconnected - login screen is the initial ConnectEmbed UI

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 27, 2025

Merge activity

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 27, 2025 19:50 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 27, 2025 19:50 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 27, 2025 19:50 Inactive
@graphite-app graphite-app bot merged commit 153651d into main Jan 27, 2025
32 checks passed
@graphite-app graphite-app bot deleted the TOOL-3241 branch January 27, 2025 19:57
@vercel vercel bot temporarily deployed to Production – docs-v2 January 27, 2025 19:57 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui January 27, 2025 19:57 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground January 27, 2025 19:57 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants