-
Notifications
You must be signed in to change notification settings - Fork 619
[TOOL-3241] Fix previous account shown after logging out in onboarding flow #6061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6061 +/- ##
=======================================
Coverage 55.01% 55.01%
=======================================
Files 1152 1152
Lines 61280 61280
Branches 5177 5177
=======================================
Hits 33716 33716
Misses 26834 26834
Partials 730 730
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
| useEffect(() => { | ||
| // if suddenly disconnected | ||
| if (connectionStatus !== "connected" && screen.id !== "login") { | ||
| setScreen({ id: "login" }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this safe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - just making sure that you are never setting an onboarding screen if wallet is disconnected - login screen is the initial ConnectEmbed UI
Merge activity
|

PR-Codex overview
This PR introduces the
onLogoutfunction into the onboarding process and modifies the login page to handle user login and logout more effectively, ensuring proper screen transitions based on the user's connection status.Detailed summary
onLogoutprop toOnboardingUIandOnboardingGeneralcomponents.handleLogoutfunction to callonLogoutafter logging out.PageContentwith anonLoginfunction to manage onboarding and login states.useEffectto handle screen state based on connection status.