Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Jan 27, 2025


title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

How to test

Unit tests, playground, etc.


PR-Codex overview

This PR focuses on updating the ecosystem name in the ecosystem.tsx file and refactoring wallet-related variables in the ManageWalletScreen.tsx to improve clarity and functionality.

Detailed summary

  • Changed the return value in ecosystem.tsx from "ecosystem.new-age" to "ecosystem.thirdweb-engs".
  • Renamed activeWallet to adminWallet in ManageWalletScreen.tsx.
  • Introduced activeWallet as a new variable using useActiveWallet().
  • Updated conditional rendering to use adminWallet instead of activeWallet for private key export.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ❌ Failed (Inspect) Jan 27, 2025 9:59pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 9:59pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 9:59pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 9:59pm

@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2025

⚠️ No Changeset found

Latest commit: 2d968c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added Playground Changes involving the Playground codebase. packages SDK Involves changes to the thirdweb SDK labels Jan 27, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.85 KB (0%) 938 ms (0%) 402 ms (+10.84% 🔺) 1.4 s
thirdweb (cjs) 123.65 KB (0%) 2.5 s (0%) 838 ms (+19.06% 🔺) 3.4 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 263 ms (+629.65% 🔺) 375 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 46 ms (+397.14% 🔺) 56 ms
thirdweb/react (minimal + tree-shaking) 19.08 KB (0%) 382 ms (0%) 147 ms (+120.02% 🔺) 529 ms

@joaquim-verges joaquim-verges merged commit e89ddb2 into main Jan 27, 2025
27 of 33 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_fix_Update_ecosystem_name_and_admin_wallet_handling branch January 27, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Playground Changes involving the Playground codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants