Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Jan 27, 2025


title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

How to test

Unit tests, playground, etc.


PR-Codex overview

This PR focuses on a patch for the thirdweb package, specifically addressing an issue related to displaying link profiles for ecosystem smart wallets.

Detailed summary

  • Added a patch for the thirdweb package.
  • Fixed the issue with showing link profiles for ecosystem smart wallets.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 10:01pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 10:01pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 10:01pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 10:01pm

@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2025

🦋 Changeset detected

Latest commit: 0a14567

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joaquim-verges joaquim-verges marked this pull request as ready for review January 27, 2025 21:58
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.85 KB (0%) 938 ms (0%) 696 ms (+34.01% 🔺) 1.7 s
thirdweb (cjs) 123.65 KB (0%) 2.5 s (0%) 1.1 s (-22.04% 🔽) 3.6 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 104 ms (+28.14% 🔺) 216 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 21 ms (+173.47% 🔺) 31 ms
thirdweb/react (minimal + tree-shaking) 19.08 KB (0%) 382 ms (0%) 184 ms (+76.13% 🔺) 566 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants