Skip to content

Conversation

@saminacodes
Copy link
Member

@saminacodes saminacodes commented Jan 28, 2025

NEB-82

Notes for the reviewer

Documentation changes

How to test

No testing needed


PR-Codex overview

This PR adds information about the contracts supported by Nebula for deployment and provides a contact link for enabling published contracts. It also maintains existing content regarding Nebula's memory and pricing.

Detailed summary

  • Added a new section titled "Which contracts does Nebula support?".
  • Listed supported contracts: Token - ERC20, NFT Collection - ERC721, Edition - ERC1155, and Split.
  • Included a contact link for enabling published contracts.
  • No significant changes to existing content on memory and pricing.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@saminacodes saminacodes requested review from a team as code owners January 28, 2025 17:00
@changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2025

⚠️ No Changeset found

Latest commit: 7d57396

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 5:25pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 5:25pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 5:25pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 5:25pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 28, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Jan 28, 2025
@codecov
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.81%. Comparing base (1616b7f) to head (6951e64).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6085   +/-   ##
=======================================
  Coverage   56.81%   56.81%           
=======================================
  Files        1152     1152           
  Lines       63906    63906           
  Branches     5178     5178           
=======================================
  Hits        36311    36311           
  Misses      26865    26865           
  Partials      730      730           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 1616b7f
packages 55.00% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.55 KB (0%) 932 ms (0%) 762 ms (+23.65% 🔺) 1.7 s
thirdweb (cjs) 122.35 KB (0%) 2.5 s (0%) 1.5 s (-28.06% 🔽) 4 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 170 ms (+270.92% 🔺) 282 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 52 ms (+10.6% 🔺) 62 ms
thirdweb/react (minimal + tree-shaking) 19.27 KB (0%) 386 ms (0%) 136 ms (-26.57% 🔽) 521 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 29, 2025

Merge activity

  • Jan 28, 8:02 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 28, 8:10 PM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Unit Tests').

NEB-82

## Notes for the reviewer

Documentation changes

## How to test

No testing needed

<!-- start pr-codex -->

---

## PR-Codex overview
This PR adds information about the contracts supported by `Nebula` and provides guidance on enabling deployment for published contracts. It also updates the section on pricing options, ensuring consistency in the text.

### Detailed summary
- Added a new section titled "Which contracts does Nebula support?" detailing supported contract types.
- Included links to `Token - ERC20`, `NFT Collection - ERC721`, `Edition - ERC1155`, and `Split` contracts.
- Provided a contact link for enabling published contracts for deployment.
- Updated the `Pricing` section for clarity, removing the newline at the end.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the saminacodes-patch-1 branch from 6951e64 to 7d57396 Compare January 29, 2025 01:03
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 29, 2025 01:03 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 29, 2025 01:03 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www January 29, 2025 01:03 Inactive
@jnsdls jnsdls merged commit 2664109 into main Jan 29, 2025
27 of 28 checks passed
@jnsdls jnsdls deleted the saminacodes-patch-1 branch January 29, 2025 18:58
@jnsdls jnsdls restored the saminacodes-patch-1 branch January 29, 2025 19:33
@jnsdls jnsdls deleted the saminacodes-patch-1 branch January 29, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants