Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Jan 28, 2025


PR-Codex overview

This PR focuses on improving error handling in the Analytics component and enhancing the Page component by ensuring that valid project and API key data are retrieved before rendering.

Detailed summary

  • In Analytics/index.tsx, error handling is improved by logging errors and returning an empty array instead of null.
  • In page.tsx, added checks to ensure project and apiKey are valid; calls notFound() if either is missing.
  • Updated clientId in the InAppWalletAnalytics component to use apiKey.key instead of params.project_slug.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel vercel bot temporarily deployed to Preview – docs-v2 January 28, 2025 20:10 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 28, 2025 20:10 Inactive
@vercel
Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 8:19pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 28, 2025 8:19pm
thirdweb_playground ⬜️ Skipped (Inspect) Jan 28, 2025 8:19pm
wallet-ui ⬜️ Skipped (Inspect) Jan 28, 2025 8:19pm

@changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2025

⚠️ No Changeset found

Latest commit: 150f829

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 28, 2025 20:10 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 28, 2025
@joaquim-verges joaquim-verges changed the title fix: Use API key for in-app wallet analytics [Dashboard] fix: Use API key for in-app wallet analytics Jan 28, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges marked this pull request as ready for review January 28, 2025 20:11
@joaquim-verges joaquim-verges requested review from a team as code owners January 28, 2025 20:11
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.55 KB (0%) 932 ms (0%) 3.9 s (+88.02% 🔺) 4.9 s
thirdweb (cjs) 122.35 KB (0%) 2.5 s (0%) 7 s (+22.05% 🔺) 9.4 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 416 ms (+81.58% 🔺) 527 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 36 ms (-4.33% 🔽) 46 ms
thirdweb/react (minimal + tree-shaking) 19.27 KB (0%) 386 ms (0%) 728 ms (+25.93% 🔺) 1.2 s

@joaquim-verges joaquim-verges merged commit 3569763 into main Jan 28, 2025
29 of 34 checks passed
@joaquim-verges joaquim-verges deleted the fix_Use_API_key_for_in-app_wallet_analytics branch January 28, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants