Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Jan 28, 2025

PR-Codex overview

This PR focuses on enhancing the secret key management functionality within the project settings. It introduces the ability to rotate secret keys and updates related UI components for better user guidance.

Detailed summary

  • Added projectId prop in several components.
  • Implemented rotateSecretKey functionality with API integration.
  • Updated UI to include confirmation prompts for rotating keys.
  • Enhanced user experience by showing new secret key after rotation.
  • Modified alerts to inform users about the implications of secret key changes.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel vercel bot temporarily deployed to Preview – docs-v2 January 28, 2025 21:05 Inactive
@vercel
Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 9:46pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 28, 2025 9:46pm
thirdweb_playground ⬜️ Skipped (Inspect) Jan 28, 2025 9:46pm
wallet-ui ⬜️ Skipped (Inspect) Jan 28, 2025 9:46pm

@linear
Copy link

linear bot commented Jan 28, 2025

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 28, 2025 21:05 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 28, 2025 21:05 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2025

⚠️ No Changeset found

Latest commit: 8dd0759

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 28, 2025
@MananTank MananTank marked this pull request as ready for review January 28, 2025 21:06
@MananTank MananTank requested review from a team as code owners January 28, 2025 21:06
Copy link
Member Author

MananTank commented Jan 28, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vercel vercel bot temporarily deployed to Preview – docs-v2 January 28, 2025 21:07 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 28, 2025 21:07 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 28, 2025 21:07 Inactive
@codecov
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.87%. Comparing base (3569763) to head (8dd0759).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6087   +/-   ##
=======================================
  Coverage   56.87%   56.87%           
=======================================
  Files        1152     1152           
  Lines       63907    63907           
  Branches     5184     5184           
=======================================
  Hits        36344    36344           
  Misses      26834    26834           
  Partials      729      729           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 3569763
packages 55.06% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.55 KB (0%) 932 ms (0%) 3.7 s (+5.18% 🔺) 4.6 s
thirdweb (cjs) 122.35 KB (0%) 2.5 s (0%) 7 s (-4.66% 🔽) 9.4 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 239 ms (-22.95% 🔽) 351 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 179 ms (+121% 🔺) 189 ms
thirdweb/react (minimal + tree-shaking) 19.27 KB (0%) 386 ms (0%) 972 ms (+97.8% 🔺) 1.4 s

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 28, 2025

Merge activity

…ngs page (#6087)

<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on enhancing the secret key management functionality within the project settings. It introduces the ability to rotate secret keys, updates related UI components, and improves user notifications regarding key management.

### Detailed summary
- Added `projectId` prop to relevant components.
- Implemented `rotateSecretKey` function for API integration.
- Updated UI to reflect secret key rotation capabilities.
- Enhanced user alerts and confirmations regarding secret key management.
- Created modal components for rotating and saving new secret keys.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 28, 2025 21:43 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 28, 2025 21:43 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 28, 2025 21:43 Inactive
@jnsdls jnsdls merged commit f5f8a40 into main Jan 28, 2025
29 checks passed
@jnsdls jnsdls deleted the TOOL-3251 branch January 28, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants