Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Jan 29, 2025

PR-Codex overview

This PR focuses on updating the rateLimit function to use team instead of project, along with the removal of the updateRateLimitedAt function. This change aims to streamline the rate limiting process by focusing on teams rather than projects.

Detailed summary

  • Updated rateLimit to accept team instead of project.
  • Removed updateRateLimitedAt function from api.ts.
  • Adjusted related code to reference team properties.
  • Updated tests to use validTeamResponse instead of validProjectResponse.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2025

🦋 Changeset detected

Latest commit: 8d18739

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 6:43pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 6:43pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 6:43pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 6:43pm

@jnsdls jnsdls marked this pull request as ready for review January 29, 2025 18:22
@jnsdls jnsdls requested a review from a team as a code owner January 29, 2025 18:22
Copy link
Member Author

jnsdls commented Jan 29, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.55 KB (0%) 932 ms (0%) 401 ms (-8.97% 🔽) 1.4 s
thirdweb (cjs) 122.35 KB (0%) 2.5 s (0%) 1.1 s (-4.74% 🔽) 3.5 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 54 ms (+64.52% 🔺) 166 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 36 ms (+24.61% 🔺) 46 ms
thirdweb/react (minimal + tree-shaking) 19.27 KB (0%) 386 ms (0%) 259 ms (+37.82% 🔺) 645 ms

@jnsdls jnsdls force-pushed the pass_team_instead_of_project_to_rateLimit branch from 43ae3ab to 8d18739 Compare January 29, 2025 18:30
@jnsdls jnsdls merged commit ee3822c into main Jan 29, 2025
26 of 29 checks passed
@jnsdls jnsdls deleted the pass_team_instead_of_project_to_rateLimit branch January 29, 2025 18:36
@joaquim-verges joaquim-verges mentioned this pull request Jan 29, 2025
@jnsdls jnsdls restored the pass_team_instead_of_project_to_rateLimit branch January 29, 2025 19:30
@jnsdls jnsdls deleted the pass_team_instead_of_project_to_rateLimit branch January 29, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants