Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Jan 29, 2025


PR-Codex overview

This PR focuses on modifying the logic for determining the chain value in the defineChain function within the packages/wagmi-adapter/src/connector.ts file.

Detailed summary

  • Changed the order of fallback values for chain:
    • lastChainId now comes first.
    • The default fallback value changed from -1 to 1.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2025

⚠️ No Changeset found

Latest commit: 1199308

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 29, 2025 7:14pm
thirdweb_playground ⬜️ Skipped (Inspect) Jan 29, 2025 7:14pm
thirdweb-www ⬜️ Skipped (Inspect) Jan 29, 2025 7:14pm
wallet-ui ⬜️ Skipped (Inspect) Jan 29, 2025 7:14pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 29, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@gregfromstl gregfromstl merged commit ebb3dcd into main Jan 29, 2025
11 of 13 checks passed
@gregfromstl gregfromstl deleted the greg/run-lint branch January 29, 2025 19:15
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.85 KB (0%) 938 ms (0%) 3 s (+19.44% 🔺) 3.9 s
thirdweb (cjs) 123.65 KB (0%) 2.5 s (0%) 7.1 s (-6.56% 🔽) 9.6 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 565 ms (+105.21% 🔺) 677 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 117 ms (-23.83% 🔽) 127 ms
thirdweb/react (minimal + tree-shaking) 19.08 KB (0%) 382 ms (0%) 766 ms (+18.03% 🔺) 1.2 s

gregfromstl added a commit that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants