Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Jan 29, 2025

TOOL-0000


PR-Codex overview

This PR addresses the usage of the wagmi adapter with account factories, ensuring that the correct chainId is utilized during wallet connections and improving the handling of chain identification.

Detailed summary

  • Updated chainId assignment in autoConnect to use chainId variable instead of lastChainId.
  • Modified the inAppWalletConnector function to consistently use chainId for account retrieval.
  • Enhanced defineChain call to prioritize inAppOptions?.chainId, lastChainId, and args.smartAccount?.chain?.id when determining the chain.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2025

🦋 Changeset detected

Latest commit: 0c2d80f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 7:35pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 7:35pm
thirdweb-www 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 7:35pm
wallet-ui 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 7:35pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 29, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.55 KB (0%) 932 ms (0%) 754 ms (+55.03% 🔺) 1.7 s
thirdweb (cjs) 122.35 KB (0%) 2.5 s (0%) 1.3 s (-8.43% 🔽) 3.8 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 138 ms (+140.89% 🔺) 249 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 32 ms (+20.57% 🔺) 42 ms
thirdweb/react (minimal + tree-shaking) 19.27 KB (0%) 386 ms (0%) 173 ms (+45.74% 🔺) 559 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants